Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/libs/ReportUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2959,13 +2959,6 @@ function isReportFieldDisabled(report: OnyxEntry<Report>, reportField: OnyxEntry
return isTitleField ? !reportField?.deletable : !isAdmin && (isReportSettled || isReportClosed);
}

/**
* Given a set of report fields, return the field of type formula
*/
function getFormulaTypeReportField(reportFields: Record<string, PolicyReportField>) {
return Object.values(reportFields).find((field) => field?.type === 'formula');
}

/**
* Given a set of report fields, return the field that refers to title
*/
Expand Down Expand Up @@ -3043,7 +3036,7 @@ function getAvailableReportFields(report: Report, policyReportFields: PolicyRepo
function getMoneyRequestReportName(report: OnyxEntry<Report>, policy?: OnyxEntry<Policy>, invoiceReceiverPolicy?: OnyxEntry<Policy>): string {
const isReportSettled = isSettled(report?.reportID ?? '-1');
const reportFields = isReportSettled ? report?.fieldList : getReportFieldsByPolicyID(report?.policyID ?? '-1');
const titleReportField = getFormulaTypeReportField(reportFields ?? {});
const titleReportField = Object.values(reportFields ?? {}).find((reportField) => reportField?.fieldID === CONST.REPORT_FIELD_TITLE_FIELD_ID);

if (titleReportField && report?.reportName && isPaidGroupPolicyExpenseReport(report)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR made these conditions unnecessary. Fixed in PR #62831.

return report.reportName;
Expand Down