Repository navigation
Update Billing-Overview.md - #54876
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@jasperhuangg @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://c79ebfe3.helpdot.pages.dev ⚡️ |
maddylewis
left a comment
There was a problem hiding this comment.
made a few more updates in the file after creating the PR
|
since this is a newer process, ill await @VictoriaExpensify's review before Jasper merges 👍 |
|
Just updated the click flow to align with our standard formatting. otherwise, all looks good |
VictoriaExpensify
left a comment
There was a problem hiding this comment.
I've updated the click-through flow on line 50
|
Just running another build for this so we can get the proper screenshots with the new changes. https://github.com/Expensify/App/actions/runs/12660786259 |
Deploying helpdot with
|
| Latest commit: |
f93eb38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b842dc5.helpdot.pages.dev |
| Branch Preview URL: | https://maddylewis-patch-7.helpdot.pages.dev |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Requested changes were handled by Victoria already
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.82-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.82-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀
|


https://github.com/Expensify/Expensify/issues/439819
context - https://expensify.slack.com/archives/C06ML6X0W9L/p1736188999194159?thread_ts=1735930614.860129&cid=C06ML6X0W9L
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined