Repository navigation
Conversation
|
@mountiny I've applied the updates similar to
The fix is easy - just update the options to So the questions are: |
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb Safari |
|
@VickyStash yes! i think we want this to be full screen |
|
@VickyStash Tooltips are coming out of the new page.
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.87-0 🚀
|
|
Tested the connection on desktop and works well! Couldn't test the final routing on staging, as you noted. Checking off for now and made a note to test again when it's deployed to prod. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀
|
Backend added these report action types for the rules engine (see Web-Expensify PR Expensify#55203).






Explanation of Change
Update the direct bank connection flow on desktop.
/bank-connection-completepage displayFixed Issues
$ #55161
PROPOSAL: N/A
Tests
Add Cardsbutton to start the feed setup (Feed selector -> Add Cards).On the desktop:After successful feed setup user should be navigated in the browser to/bank-connection-completeroute. If user returns to the desktop app he sees that the new feed is successfully added.!IMPORTANT NOTE: After successful feed setup user re-directed to
https://new.expensify.com/bank-connection-complete, if this PR wasn't deploy to production, you will not see the expected page. To see the expected one change the URL to start withhttps://dev.new.expensify.com:8082/On the web:Ensure the bank browser window is closed and a new feed is successfully added.Offline tests
N/A
QA Steps
Same, as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
web1.mp4
MacOS: Desktop
desktop1.mp4