Repository navigation
Fix saved search no hiding modal - #57105
luacmartins merged 4 commits into
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeScreen.Recording.2025-02-19.at.11.09.30.PM.moviOS: NativeScreen.Recording.2025-02-19.at.11.01.32.PM.moviOS: mWeb SafariScreen.Recording.2025-02-20.at.9.42.59.PM.movMacOS: Chrome / SafariScreen.Recording.2025-02-20.at.9.41.14.PM-1.movMacOS: DesktopScreen.Recording.2025-02-20.at.9.48.40.PM.mov |
|
bug: clicking on saved search on web does nothing Screen.Recording.2025-02-19.at.10.50.04.PM.mov |
|
weird bug on ios safari (reproducible on main also) popover does not close properly and screen freezes on clicking saved search Screen.Recording.2025-02-19.at.11.15.07.PM.mov |
|
@sumo-slonik we have some bugs ^ |
|
@ishpaul777 maybe this issue is the same as reported here. It should be fixed on latest main though 🤔 #57068 |
|
@luacmartins i can reproduce this on prod as well Screen.Recording.2025-02-20.at.12.31.42.AM.movthis one is main blocker I guess |
|
Looking |
|
🚧 @francoisl has triggered a test hybrid app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
| onPress: () => { | ||
| clearAllFilters(); | ||
| Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: item?.query ?? '', name: item?.name})); | ||
| }, |
There was a problem hiding this comment.
reverting these changes will fix the issue on web
There was a problem hiding this comment.
yea, but it brings the original issue back, no?
There was a problem hiding this comment.
I managed to fix it
|
I tried fixing this issue with the changes in this PR, but that introduced another issue. You can see it in the video below. After changing pages several times, we end up in the selected state 🤔 ScreenRecording_02-19-2025.17-02-10_1.MP4Additionally, there's something else going on with this popover menu. It seems like it doesn't work properly on small screen web (this is also in prod). Screen.Recording.2025-02-19.at.5.42.30.PM.mov |
luacmartins
left a comment
There was a problem hiding this comment.
Left a comment with some bugs that we found
|
I'm checking what happened |
I think I know why it happened, I am already trying to fix it
It seems to me that this bug is not related to my changes, but I will try to fix it as well |
I also added onPress already to fix the web, I will try to solve the problem you show in the video |
|
@sumo-slonik can you please fix lint |
|
|
reviewing again |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.3-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.3-4 🚀
|
Explanation of Change
Fixed the problem which was the double navigation resulting from the presence of onPress and onSelect at the same time
Fixed Issues
$ #57068
PROPOSAL:
Tests
Precondition:
Offline tests
Unnesesary
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-02-19.at.15.15.58.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-02-19.at.14.39.24.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop