Skip to content

[No QA] Remove redundant prettier rule #57172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 1 commit into from
Feb 26, 2025
+4 −1
Merged

[No QA] Remove redundant prettier rule #57172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ web/gtm.js
src/libs/SearchParser/searchParser.js
src/libs/SearchParser/autocompleteParser.js
help/_scripts/**
Mobile-Expensify/**

@289Adam289 289Adam289 Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint breaks locally for developers with access to Mobile-Expensify. Adding Mobile-Expensify to .eslintignore fixes the problem.

4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ module.exports = {
'plugin:@typescript-eslint/recommended-type-checked',
'plugin:@typescript-eslint/stylistic-type-checked',
'plugin:you-dont-need-lodash-underscore/all',
'plugin:prettier/recommended',
'prettier',
],
plugins: ['@typescript-eslint', 'jsdoc', 'you-dont-need-lodash-underscore', 'react-native-a11y', 'react', 'testing-library', 'eslint-plugin-react-compiler', 'lodash', 'deprecation'],
parser: '@typescript-eslint/parser',
Expand Down Expand Up @@ -203,6 +203,7 @@ module.exports = {
'es/no-nullish-coalescing-operators': 'off',
'es/no-optional-chaining': 'off',
'deprecation/deprecation': 'off',
'arrow-body-style': 'off',

@289Adam289 289Adam289 Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule was suppressed by prettier-plugin but is not suppressed by prettier-config. Leaving it on, results in 153 ESLint errors. You can find more information about this rule on https://eslint.org/docs/latest/rules/arrow-body-style
Similar problem is with prefer-arrow-callback rule for .js files


// Import specific rules
'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
Expand Down Expand Up @@ -308,6 +309,7 @@ module.exports = {
'jsdoc/no-types': 'off',
'react/jsx-filename-extension': 'off',
'rulesdir/no-default-props': 'off',
'prefer-arrow-callback': 'off',
},
},
{
Expand Down