Fix - Sage Intacct - Preferred exporter remains the same after changing the role of admin to member by FitseTLT · Pull Request #57430 · Expensify/App

FitseTLT · 2025-02-25T20:40:30Z

Details

Fixed Issues

Tests

Prerequisite
An account with a workspace connected to an Accounting Software: this test should be done for all 5 accounting integrations

Go to members > Invite > Choose the role as Admin > Finish the flow
Navigate to accounting > Export > Preferred exporter > Change the exporter to the newly invited admin
Go offline
Go to members > Change the role of the newly invited admin to other role (or remove the user from the workspace)
Go back to Preferred exporter page and check the exporter
Verify that Preferred exporter menu is greyed out and the preferred exporter is changed back to the owner of the workspace
If you have removed the admin in step (4): click on the preferred exporter menu and verify that the user you removed from workspace doesn't appear in the exporters list anymore.
Go online
Verify the exporter will remain to be the owner 👍

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

aa.mp4

Android: mWeb Chrome

aww.mp4

iOS: Native

ii.mp4

iOS: mWeb Safari

iww.mp4

MacOS: Chrome / Safari

ww.mp4

MacOS: Desktop

2025-02-25.23-39-49.mp4

melvin-bot · 2025-02-25T20:40:36Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb

Let's make sure code changes are super concise.

…n-admin-removed

dominictb · 2025-03-03T12:05:27Z

+        /** Collections of form field errors */
+        errorFields?: OnyxCommon.ErrorFields;
+    },
+    'exporter'


Can you explain these changes?

As u can see here

App/src/pages/workspace/accounting/qbd/export/QuickbooksDesktopPreferredExporterConfigurationPage.tsx

Line 92 in dfd9dae

pendingAction={PolicyUtils.settingsPendingAction([CONST.QUICKBOOKS_DESKTOP_CONFIG.EXPORTER], qbdConfig?.pendingFields)}

we are using pendingField.exporter for QBD but the type doesn't have it, so I am adding it.

To align with other connections' config type, let's extract the QBDExportConfig and use it as keys for pending action. For example:

App/src/types/onyx/Policy.ts

Line 1347 in dae7718

SageIntacctOfflineStateKeys | keyof SageIntacctSyncConfig | keyof SageIntacctAutoSyncConfig | keyof SageIntacctExportConfig

FitseTLT · 2025-03-03T15:19:37Z

Yeah I know, but if he's currently a normal member, then get promoted to an auditor. In that case, the newRole would be AUDITOR, right? So we would call resetAccountingPreferredExporter which is not necessary. I think the correct condition should be that the CURRENT role is ADMIN.

@dominictb we are updating roles of multiple users, so the only condition we can avoid calling resetAccountingPreferredExporter is when the new role is admin in other cases there can be users in accountIDs list that are admins so it will be handled inside the function.

dominictb · 2025-03-04T19:18:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-06.at.01.56.00.mov

Screen.Recording.2025-03-06.at.01.53.45-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-03-06.at.02.01.12.mov

Screen.Recording.2025-03-06.at.01.59.00.mov

iOS: Native

Screen.Recording.2025-03-06.at.01.35.19.mov

iOS: mWeb Safari

Screen.Recording.2025-03-06.at.01.48.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-06.at.00.32.34.mov

Screen.Recording.2025-03-06.at.00.34.27.mov

MacOS: Desktop

Screen.Recording.2025-03-06.at.01.23.04.mov

Screen.Recording.2025-03-06.at.01.22.32.mov

dominictb · 2025-03-04T21:02:55Z

+        /** Collections of form field errors */
+        errorFields?: OnyxCommon.ErrorFields;
+    },
+    'exporter'


To align with other connections' config type, let's extract the QBDExportConfig and use it as keys for pending action. For example:

App/src/types/onyx/Policy.ts

Line 1347 in dae7718

SageIntacctOfflineStateKeys | keyof SageIntacctSyncConfig | keyof SageIntacctAutoSyncConfig | keyof SageIntacctExportConfig

…n-admin-removed

dominictb · 2025-03-05T17:38:18Z

@FitseTLT BUG: The removed preferred exporter from the workspace still shows in exporter config list:

Set an admin as accounting's exporter
Go offline
Remove him from the workspace
Go to the accounting exporter settings
Observe that he's still in the exporter list (even though the owner is selected)

Screen.Recording.2025-03-06.at.00.35.48.mov

…n-admin-removed

FitseTLT · 2025-03-05T18:43:52Z

@dominictb this is not directly linked to this issue but do you still think we should filter-out pending delete admin employees from the list here?

dominictb · 2025-03-05T18:51:16Z

@FitseTLT Please help fix it & add corresponding test steps.

FitseTLT · 2025-03-05T19:06:00Z

Done

dominictb · 2025-03-05T19:07:46Z

Tested well.

dominictb

LGTM 🎀👀🎀

OSBotify · 2025-03-05T20:11:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-06T23:15:11Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:10:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

reset preferred exporter when admin is removed

dae7718

FitseTLT requested a review from a team as a code owner February 25, 2025 20:40

melvin-bot Bot requested review from dominictb and removed request for a team February 25, 2025 20:40

dominictb suggested changes Feb 26, 2025

View reviewed changes

FitseTLT added 2 commits February 27, 2025 17:38

Merge branch 'main' into fix-update-preferred-accounting-exporter-whe…

c4ee248

…n-admin-removed

refactor code

f4d23c5

FitseTLT requested a review from dominictb February 27, 2025 15:48

dominictb suggested changes Mar 3, 2025

View reviewed changes

minor update

dfd9dae

dominictb suggested changes Mar 4, 2025

View reviewed changes

FitseTLT added 2 commits March 5, 2025 01:19

Merge branch 'main' into fix-update-preferred-accounting-exporter-whe…

7e5b0a2

…n-admin-removed

updated based on comments

cedd152

FitseTLT requested a review from dominictb March 4, 2025 22:35

dominictb suggested changes Mar 5, 2025

View reviewed changes

Comment thread src/types/onyx/Policy.ts Resolved

FitseTLT added 2 commits March 5, 2025 21:37

Merge branch 'main' into fix-update-preferred-accounting-exporter-whe…

e4e7a9e

…n-admin-removed

update comment

5db1d57

avoid deleted employee in exporter list

66a9a76

dominictb approved these changes Mar 5, 2025

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon March 5, 2025 19:08

yuwenmemon approved these changes Mar 5, 2025

View reviewed changes

yuwenmemon merged commit e155c58 into Expensify:main Mar 5, 2025

github-actions Bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks done

melvin-bot Bot mentioned this pull request Mar 10, 2025

[Due for payment 2025-03-17] [$250] Sage Intacct - Preferred exporter remains the same after changing the role of admin to member #55729

Closed

3 of 8 tasks

Conversation

FitseTLT commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 25, 2025

Uh oh!

dominictb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominictb Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FitseTLT commented Mar 3, 2025

Uh oh!

dominictb commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dominictb commented Mar 5, 2025

Uh oh!

FitseTLT commented Mar 5, 2025

Uh oh!

dominictb commented Mar 5, 2025

Uh oh!

FitseTLT commented Mar 5, 2025

Uh oh!

dominictb commented Mar 5, 2025

Uh oh!

dominictb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 5, 2025

Uh oh!

github-actions Bot commented Mar 6, 2025

Uh oh!

github-actions Bot commented Mar 10, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FitseTLT commented Feb 25, 2025 •

edited

Loading

dominictb left a comment •

edited

Loading

dominictb commented Mar 4, 2025 •

edited

Loading

dominictb left a comment •

edited

Loading