Skip to content

Upgrade RN to 63.3 and remove patch package - #580

Merged
AndrewGable merged 3 commits into
masterfrom
joe-remove-patch-package
Oct 8, 2020
Merged

AndrewGable merged 3 commits into
masterfrom
joe-remove-patch-package

Conversation

@Jag96

@Jag96 Jag96 commented Oct 1, 2020 •

Copy link
Copy Markdown
Contributor

@timszot @cead22 will you please review this?
cc @tgolen @AndrewGable

When implementing #463, there was a bug with React Native version 0.63.2 that caused loading local images from the camera/library to fail: react/react-native#29364. To fix this issue, I added a patch using patch-package to temporarily patch the issue until the fix for the RN bug was released. 0.63.3 has been released, and it seems to have fixed the issue, so this PR reverts the patch-package change and updates RN to include the fix.

Fixed Issues

Related to #463

Tests

  1. Make sure you run npm install; cd ios; pod install; before testing. Also, if you're testing Android on an emulator, be sure to clean w/ cd android && ./gradlew clean
  2. On Desktop and Web, confirm you can upload a file and an image onto a chat report
  3. On iOS and Android, confirm you can upload an image from the library as well as a picture from the camera

@Jag96
Jag96 requested review from cead22 and timszot October 1, 2020 21:07
@Jag96 Jag96 self-assigned this Oct 1, 2020
@AndrewGable

Copy link
Copy Markdown
Contributor

So reading the release notes: https://github.com/facebook/react-native/releases/tag/v0.63.3

It mentions using this tool: https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.3 to update.

Should we apply those native changes as well? I think we probably do have to make those changes manually or by using the upgrade command.

@cead22 cead22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of reverting that patch 👍 but sounds like @roryabraham is suggesting we're missing some steps

@roryabraham

Copy link
Copy Markdown
Contributor

@cead22 This is the first I've heard of it - maybe you were thinking of someone else?

Only suggestion I have is to change testing step 0 to run npm install; cd ios; pod deintegrate; pod install;

@cead22

cead22 commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Heh, sorry I meant to tag @AndrewGable, I don't know why I tagged you, I was referring to Andrew's comment above about the upgrade command

@Jag96

Jag96 commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@AndrewGable this upgrade is from 63.2 to 63.3, not 62.2 to 63.3: https://react-native-community.github.io/upgrade-helper/?from=0.63.2&to=0.63.3

But yes looks like the flipper upgrade wasn't pushed there, will update.

@Jag96

Jag96 commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Updated and re-tested after merging with master as well

@timszot timszot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewGable
AndrewGable merged commit 1aa91c5 into master Oct 8, 2020
@AndrewGable
AndrewGable deleted the joe-remove-patch-package branch October 8, 2020 18:02
sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
Upgrade RN to 63.3 and remove patch package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants