Skip to content

Convert the store to using promises - #6

Merged
AndrewGable merged 12 commits into
masterfrom
tgolen-async-promise
Aug 8, 2020
Merged

AndrewGable merged 12 commits into
masterfrom
tgolen-async-promise

Conversation

@tgolen

@tgolen tgolen commented Aug 8, 2020

Copy link
Copy Markdown
Contributor
  • Removes .js from imports to remove an eslint error
  • Organizes the CONFIG constant better
  • Updates the code in ReportActions.js to the recent code from the web POC
  • Adds multiGet, multiSet, and merge to the store
  • Removes all async/await in the store/action/network files

@tgolen
tgolen requested a review from AndrewGable August 8, 2020 18:50
@tgolen tgolen self-assigned this Aug 8, 2020
@AndrewGable
AndrewGable merged commit e70f822 into master Aug 8, 2020
@tgolen
tgolen deleted the tgolen-async-promise branch August 8, 2020 19:26
AndrewGable pushed a commit that referenced this pull request Mar 4, 2021
add catch net for missing/invalid SEMVER_LEVEL
Julesssss pushed a commit that referenced this pull request Apr 7, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@stitesExpensify stitesExpensify mentioned this pull request Oct 12, 2021
2 of 11 tasks
@hayata-suenaga hayata-suenaga mentioned this pull request Oct 13, 2023
58 tasks
techievivek pushed a commit that referenced this pull request Nov 28, 2023
Even with expensify/main
@github-actions github-actions Bot mentioned this pull request Nov 29, 2023
55 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.5-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

MrMuzyk pushed a commit to MrMuzyk/App that referenced this pull request Jan 23, 2024
* feat: added hook for submit step

* feat: preventa automatically update values in editing mode in PersonalInfo

* fix: changed name of kys array

* fix: move\ hook to the main directory

* feat: applied to the BankInfo step

* feat: applied to the UBO steps

* fix: lint fixes

* refactorL: standarize variable names
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Feb 13, 2024 •

Copy link
Copy Markdown

Deploying helpdot with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3560bc
Status: ✅  Deploy successful!
Preview URL: https://61d8d4b1.helpdot.pages.dev

View logs

@elirangoshen elirangoshen mentioned this pull request Feb 20, 2026
51 tasks done
tgolen added a commit that referenced this pull request Mar 2, 2026
…nect-shared-billing-grace-period-subscription-utils-6

#6 - Get the billing grace end period collection with useOnyx
iwiznia pushed a commit that referenced this pull request Jun 5, 2026
#6 — Add Editor case to roleBadgeText in WorkspaceMembersPage so the
accessibility label includes 'Editor' for Submit workspace members
(the visual badge was already correct via MemberRightIcon).

#8 — Guard updateWorkspaceMembersRole against Submit workspaces.
The UI already blocks role changes via isInteractive:false and
isPaidGroupPolicy checks, but the action itself was unguarded.
This closes the gap against future programmatic call sites.
mountiny pushed a commit that referenced this pull request Jun 18, 2026
- getLength() does not gate read-blocking: drop the claim; waitForWrites
  always awaits waitForSequentialQueueIdle() (isReadyPromise) regardless
  of count (MelvinBot)
- Reauthentication throws new Error('Failed to reauthenticate') (MelvinBot)
- Qualify persist-before-fire to post-init only; pre-init save() returns
  Promise.resolve() and the enqueue write is deferred + un-awaited (Codex P2)
- isQueuePaused is a data-gap/deferred-update pause only, not offline;
  offline is a separate isOfflineNetwork() check. Add Open Question #6 on
  the misleading source comment (Codex P3)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
…ersioning

add catch net for missing/invalid SEMVER_LEVEL
sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants