Repository navigation
fix: expense preview has the same background as message row - #60205
Conversation
|
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
|
@daledah can you please address that border radius comment? |
@mountiny @shawnborton i updated |
|
That looks better. But I'm curious why you had to manually add that? Shouldn't the report preview card be some kind of global component? |
|
It is a global component but its not the same component as the request preview inside of it if that is what you mean |
|
No I'm just wondering, why do we need to manually add border radius styles here in this specific case? The expense report preview should always have those styles baked in, no matter where we use it. Does that make sense? |
|
It makes sense that we need to add a border color/stroke for this particular case, but the border radius should always be the same, no matter where we call this thing. |
|
Yeah, that is true, but it seems like this new report preview never had this radius. The old preview does have it but its a different component so we can deploy these fine behind beta (if it would be the same component it would be hard to hide this) |
| }} | ||
| shouldUseHapticsOnLongPress | ||
| style={[styles.flexRow, styles.justifyContentBetween, StyleUtils.getBackgroundColorStyle(theme.cardBG), styles.reportContainerBorderRadius]} | ||
| style={[styles.flexRow, styles.justifyContentBetween, StyleUtils.getBackgroundColorStyle(theme.cardBG), styles.reportContainerBorderRadius, styles.borderedContentCardLarge]} |
There was a problem hiding this comment.
Or rather the bordered radius
|
Ahhhh that makes sense! Okay, thanks for confirming here. |
|
@daledah were the issues addressed, if so please update platform images ! |
|
I'll update all the screenshots soon |
|
All screenshots updated. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Ah, we have a regression - we are ONLY supposed to show the border from within the Reports > Chats view. Not in the Inbox: @daledah can you please prepare a fix? |
|
I'll raise a follow up PR soon @shawnborton |
|
Thanks! |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.29-0 🚀
|
|
@daledah any update on the follow up? |
|
@shawnborton I'll open the follow up PR in 1-2 hours |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀
|










Explanation of Change
Fixed Issues
$ #59975
PROPOSAL: #59975 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop