Repository navigation
[Multi-tags]: Add beta and ability to download tags #61866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fcbec0c
8d00540
ae3e3a9
b895faf
8a88a5d
2ecb6cb
2439690
071ebdc
fe3a0ec
d9c5c90
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| type ExportMultiLevelTagsSpreadSheetParams = { | ||
| /** ID of the policy */ | ||
| policyID: string; | ||
| }; | ||
|
|
||
| export default ExportMultiLevelTagsSpreadSheetParams; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -763,6 +763,13 @@ function hasDependentTags(policy: OnyxEntry<Policy>, policyTagList: OnyxEntry<Po | |
| return Object.values(policyTagList ?? {}).some((tagList) => Object.values(tagList.tags).some((tag) => !!tag.rules?.parentTagsFilter || !!tag.parentTagsFilter)); | ||
| } | ||
|
|
||
| function hasIndependentTags(policy: OnyxEntry<Policy>, policyTagList: OnyxEntry<PolicyTagLists>) { | ||
| if (!policy?.hasMultipleTagLists) { | ||
| return false; | ||
| } | ||
| return Object.values(policyTagList ?? {}).every((tagList) => Object.values(tagList.tags).every((tag) => !tag.rules?.parentTagsFilter && !tag.parentTagsFilter)); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @allgandalf I am getting this error on all my existing sessions. Once I am logout and login again it goes away. Best to add
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @allgandalf Were you able to follow-up on this?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| } | ||
|
|
||
| /** Get the Xero organizations connected to the policy */ | ||
| function getXeroTenants(policy: Policy | undefined): Tenant[] { | ||
| // Due to the way optional chain is being handled in this useMemo we are forced to use this approach to properly handle undefined values | ||
|
|
@@ -1537,6 +1544,7 @@ export { | |
| getActiveEmployeeWorkspaces, | ||
| isUserInvitedToWorkspace, | ||
| getPolicyRole, | ||
| hasIndependentTags, | ||
| }; | ||
|
|
||
| export type {MemberEmailsToAccountIDs}; | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to rename the label as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was mentioned in the design doc, the backend for that is not yet updated, asked for details https://expensify.enterprise.slack.com/archives/C07HPDRELLD/p1747381834260859?thread_ts=1747095451.933699&channel=C07HPDRELLD&message_ts=1747381834.260859
lets see what we hear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i am holding to rename the label for now, else i am going to revert that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend is updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.