You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAID - WAITING ON CHECKLIST] Android - Missing "Employees see tags as State" after deleting tag #82573
Version Number: 9.3.20-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82218 Email or phone of affected tester (no customers):sjiondjsondjoisjsojdos@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Precondition:
Tags are enabled.
Launch Expensify app.
Go to workspace settings > Tags.
Tap Import.
Tap Multi-level tags.
Upgrade workspace if needed.
Disable "These are independent tags".
Enable "There is a GL code in the adjacent column".
Tap Import > Got it.
Delete all the tag.
Expected Result:
After deleting the tag, "Employees see tags as State" will show up on the empty state.
Actual Result:
After deleting the tag, "Employees see tags as State" is missing on the empty state.
It reappears after reopening Tags page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #82218 - "Fix: Tags description "You're using dependent tags..." has a distorted view" by @nyomanjyotisa (High confidence) Related Issues: #70991 (original issue that PR #82218 fixed)
Recommendation: REVERT
PR #82218 introduced a regression in the subtitle rendering logic for the Tags page. While it fixed the distorted view issue, it broke the display of the "Employees see tags as [State]" text after deleting all tags. The text only reappears after reopening the page, indicating a state update issue in the restructured getHeaderSubtitle() function.
Labels: Keeping DeployBlockerCash as this is a frontend bug affecting the App. The issue is only reproducible on staging (not production) and was caused by an App PR.
📋 Detailed Analysis
Evidence
The issue was reported on staging version 9.3.20-0 and is not reproducible in production
The behavior (text missing after deletion but reappearing on page reload) indicates a rendering/state issue introduced by the code restructure
Verification
PR #82218 modified src/pages/workspace/tags/WorkspaceTagsPage.tsx, specifically the subtitle rendering logic in the getHeaderSubtitle() function (lines 677-715 in current version).
What changed:
Before: Subtitle was rendered conditionally using separate <Text> components with inline conditional logic
After: Restructured to use a dedicated getHeaderSubtitle() function that returns different JSX based on conditions, with dependent tags case now using RenderHTML with combined subtitle text
When tags are deleted after importing with dependent tags enabled:
The hasDependentTags value may not update immediately to reflect the empty state
OR the condition ordering causes the code to fall through to the final return statement which uses RenderHTML
The final return doesn't account for the empty tags case with dependent tags configuration
The fact that the text reappears after reopening the page suggests that the state (hasDependentTags or policyTagLists) is not being updated correctly on deletion, but is correctly computed when the page remounts.
Root Cause
The restructured conditional logic in getHeaderSubtitle() doesn't properly handle the edge case where:
Dependent tags were configured (imported with multi-level dependent tags)
All tags are subsequently deleted
The subtitle should show "Employees see tags as [State]" but doesn't because the flow goes to the wrong branch in the conditional logic
This is a UI state management issue where the computed values (hasDependentTags) don't reflect the current tag state after deletion until the page is reloaded.
📣 @apeyada 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-][$250] Android - Missing "Employees see tags as State" after deleting tag[/-][+][PAID - WAITING ON CHECKLIST] Android - Missing "Employees see tags as State" after deleting tag[/+]on Mar 23, 2026
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to workspace settings > Tags.
Tap Import.
Tap Multi-level tags.
Upgrade workspace if needed.
Disable "These are independent tags".
Enable "There is a GL code in the adjacent column".
Tap Import > Got it.
Delete all the tag.
Verify that "Employees see tags as State" will show up on the empty state.
Activity
melvin-bot commentedon Feb 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82218
melvin-bot commentedon Feb 16, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 16, 2026
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 16, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #82218 - "Fix: Tags description "You're using dependent tags..." has a distorted view" by @nyomanjyotisa (High confidence)
Related Issues: #70991 (original issue that PR #82218 fixed)
Recommendation: REVERT
PR #82218 introduced a regression in the subtitle rendering logic for the Tags page. While it fixed the distorted view issue, it broke the display of the "Employees see tags as [State]" text after deleting all tags. The text only reappears after reopening the page, indicating a state update issue in the restructured
getHeaderSubtitle()function.Labels: Keeping
DeployBlockerCashas this is a frontend bug affecting the App. The issue is only reproducible on staging (not production) and was caused by an App PR.📋 Detailed Analysis
Evidence
Verification
PR #82218 modified
src/pages/workspace/tags/WorkspaceTagsPage.tsx, specifically the subtitle rendering logic in thegetHeaderSubtitle()function (lines 677-715 in current version).What changed:
<Text>components with inline conditional logicgetHeaderSubtitle()function that returns different JSX based on conditions, with dependent tags case now usingRenderHTMLwith combined subtitle textThe bug:
The condition at line 691-696 checks:
When tags are deleted after importing with dependent tags enabled:
hasDependentTagsvalue may not update immediately to reflect the empty statereturnstatement which usesRenderHTMLThe fact that the text reappears after reopening the page suggests that the state (
hasDependentTagsorpolicyTagLists) is not being updated correctly on deletion, but is correctly computed when the page remounts.Root Cause
The restructured conditional logic in
getHeaderSubtitle()doesn't properly handle the edge case where:This is a UI state management issue where the computed values (
hasDependentTags) don't reflect the current tag state after deletion until the page is reloaded.situchan commentedon Feb 16, 2026
Checking. Please assign me here.
29 remaining items
melvin-bot commentedon Feb 24, 2026
📣 @apeyada 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Mar 23, 2026
This issue has not been updated in over 15 days. @NikkiWines, @jliexpensify, @situchan, @apeyada eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
jliexpensify commentedon Mar 23, 2026
Oh damn, automation broke here!
jliexpensify commentedon Mar 23, 2026
Payment Summary
jliexpensify commentedon Mar 23, 2026
Paid and job closed - @situchan can you complete the checklist please?
[-][$250] Android - Missing "Employees see tags as State" after deleting tag[/-][+][PAID - WAITING ON CHECKLIST] Android - Missing "Employees see tags as State" after deleting tag[/+]jliexpensify commentedon Mar 30, 2026
Bump @situchan on checklist plz
situchan commentedon Mar 30, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/61866/changes#r3007245633
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎