Skip to content

[PAID - WAITING ON CHECKLIST] Android - Missing "Employees see tags as State" after deleting tag #82573

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.20-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82218
Email or phone of affected tester (no customers): sjiondjsondjoisjsojdos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

Precondition:

  • Tags are enabled.
  1. Launch Expensify app.
  2. Go to workspace settings > Tags.
  3. Tap Import.
  4. Tap Multi-level tags.
  5. Upgrade workspace if needed.
  6. Disable "These are independent tags".
  7. Enable "There is a GL code in the adjacent column".
  8. Tap Import > Got it.
  9. Delete all the tag.

Expected Result:

After deleting the tag, "Employees see tags as State" will show up on the empty state.

Actual Result:

After deleting the tag, "Employees see tags as State" is missing on the empty state.
It reappears after reopening Tags page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

Dependent_-_Multi_Level_tags_NEWW.csv

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022026094737843700927
  • Upwork Job ID: 2026094737843700927
  • Last Price Increase: 2026-02-24
  • Automatic offers:
    • situchan | Reviewer | 110560180
    • apeyada | Contributor | 110560182

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 16, 2026
  2. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #82218

  3. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 16, 2026

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 16, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #82218 - "Fix: Tags description "You're using dependent tags..." has a distorted view" by @nyomanjyotisa (High confidence)
    Related Issues: #70991 (original issue that PR #82218 fixed)

    Recommendation: REVERT

    PR #82218 introduced a regression in the subtitle rendering logic for the Tags page. While it fixed the distorted view issue, it broke the display of the "Employees see tags as [State]" text after deleting all tags. The text only reappears after reopening the page, indicating a state update issue in the restructured getHeaderSubtitle() function.

    Labels: Keeping DeployBlockerCash as this is a frontend bug affecting the App. The issue is only reproducible on staging (not production) and was caused by an App PR.

    📋 Detailed Analysis

    Evidence

    Verification

    PR #82218 modified src/pages/workspace/tags/WorkspaceTagsPage.tsx, specifically the subtitle rendering logic in the getHeaderSubtitle() function (lines 677-715 in current version).

    What changed:

    • Before: Subtitle was rendered conditionally using separate <Text> components with inline conditional logic
    • After: Restructured to use a dedicated getHeaderSubtitle() function that returns different JSX based on conditions, with dependent tags case now using RenderHTML with combined subtitle text

    The bug:
    The condition at line 691-696 checks:

    if (!hasDependentTags && !hasIndependentTags && !!policyTagLists.at(0)?.name) {
        return (
            <Text style={[styles.textNormal, styles.colorMuted]}>
                <EmployeesSeeTagsAsText customTagName={policyTagLists.at(0)?.name ?? ''} />
            </Text>
        );
    }

    When tags are deleted after importing with dependent tags enabled:

    1. The hasDependentTags value may not update immediately to reflect the empty state
    2. OR the condition ordering causes the code to fall through to the final return statement which uses RenderHTML
    3. The final return doesn't account for the empty tags case with dependent tags configuration

    The fact that the text reappears after reopening the page suggests that the state (hasDependentTags or policyTagLists) is not being updated correctly on deletion, but is correctly computed when the page remounts.

    Root Cause

    The restructured conditional logic in getHeaderSubtitle() doesn't properly handle the edge case where:

    • Dependent tags were configured (imported with multi-level dependent tags)
    • All tags are subsequently deleted
    • The subtitle should show "Employees see tags as [State]" but doesn't because the flow goes to the wrong branch in the conditional logic

    This is a UI state management issue where the computed values (hasDependentTags) don't reflect the current tag state after deletion until the page is reloaded.

  7. situchan commented on Feb 16, 2026

    @situchan
    Contributor

    Checking. Please assign me here.

  8. 29 remaining items

  9. melvin-bot commented on Feb 24, 2026

    @melvin-bot

    📣 @apeyada 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @NikkiWines, @jliexpensify, @situchan, @apeyada eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. jliexpensify commented on Mar 23, 2026

    @jliexpensify
    Contributor

    Oh damn, automation broke here!

  12. jliexpensify commented on Mar 23, 2026

    @jliexpensify
    Contributor

    Payment Summary

    • C: @apeyada $250 (to be paid via Upworks)
    • C+: @situchan $250 (to be paid via Upworks)
  13. jliexpensify commented on Mar 23, 2026

    @jliexpensify
    Contributor

    Paid and job closed - @situchan can you complete the checklist please?

  14. changed the title [-][$250] Android - Missing "Employees see tags as State" after deleting tag[/-] [+][PAID - WAITING ON CHECKLIST] Android - Missing "Employees see tags as State" after deleting tag[/+] on Mar 23, 2026
  15. jliexpensify commented on Mar 30, 2026

    @jliexpensify
    Contributor

    Bump @situchan on checklist plz

  16. situchan commented on Mar 30, 2026

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/61866/changes#r3007245633

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Go to workspace settings > Tags.
    2. Tap Import.
    3. Tap Multi-level tags.
    4. Upgrade workspace if needed.
    5. Disable "These are independent tags".
    6. Enable "There is a GL code in the adjacent column".
    7. Tap Import > Got it.
    8. Delete all the tag.
    9. Verify that "Employees see tags as State" will show up on the empty state.

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions