Repository navigation
fix Lottie Animation Scaling and container width in Trips Empty State Illustration #61996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grgia
merged 8 commits into
Expensify:main
from
nabi-ebrahimi:fix/trips-empty-state-illustration-size
May 16, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
93de73f
fix: resize Trips empty state illustration to maintain aspect ratio a…
361cf0d
Set Lottie container width and height to 100% for consistent sizing a…
9d3c650
Use fixed width and height for Lottie container on small screens, and…
1235fcf
Add isSmallScreen to useMemo dependency array in EmptySearchView comp…
a2e5472
Set min-width to container as well to keep border-radius on native pl…
80b8d5b
Set fixed width and height to lottie view and '100%' to container
cbfa944
moved styles into styles file
dc70591
updated useMemo dependencies
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change , I don't think it's needed here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to either update the type of the
headerContentStylesprop or leave it as is, since removing it leads to a type error.Currently, its type is
ViewStyle & ImageStylein theEmptyStateComponent, so we’d also need to update the types inEmptyStateComponentaccordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the styling is consistent across other
headerContentStyles, why isCONST.SEARCH.DATA_TYPES.TRIPthe only one throwing a type error?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other cases in the switch include
!hasResults, which hinders TypeScript's ability to infer types accurately.For example, returning this value in the first case causes type errors that are handled correctly in the default case.