Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/MoneyReportHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -533,14 +533,14 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea
),
};

const {canUseRetractNewDot} = usePermissions();
const {canUseRetractNewDot, canUseTableReportView} = usePermissions();

const secondaryActions = useMemo(() => {
if (!moneyRequestReport) {
return [];
}
return getSecondaryReportActions(moneyRequestReport, transactions, violations, policy, reportNameValuePairs, reportActions, canUseRetractNewDot);
}, [moneyRequestReport, transactions, violations, policy, reportNameValuePairs, reportActions, canUseRetractNewDot]);
return getSecondaryReportActions(moneyRequestReport, transactions, violations, policy, reportNameValuePairs, reportActions, canUseRetractNewDot, canUseTableReportView);
}, [moneyRequestReport, transactions, violations, policy, reportNameValuePairs, reportActions, canUseRetractNewDot, canUseTableReportView]);

const secondaryActionsImplementation: Record<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>, DropdownOption<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>>> = {
[CONST.REPORT.SECONDARY_ACTIONS.VIEW_DETAILS]: {
Expand Down
3 changes: 2 additions & 1 deletion src/libs/ReportSecondaryActionUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,11 @@ function getSecondaryReportActions(
reportNameValuePairs?: ReportNameValuePairs,
reportActions?: ReportAction[],
canUseRetractNewDot?: boolean,
canUseTableReportView?: boolean,
): Array<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>> {
const options: Array<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>> = [];

if (isAddExpenseAction(report, reportTransactions)) {
if (canUseTableReportView && isAddExpenseAction(report, reportTransactions)) {
options.push(CONST.REPORT.SECONDARY_ACTIONS.ADD_EXPENSE);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/ReportSecondaryActionUtilsTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('getSecondaryAction', () => {
transactionID: TRANSACTION_ID,
} as unknown as Transaction;

const result = getSecondaryReportActions(report, [transaction], {}, policy);
const result = getSecondaryReportActions(report, [transaction], {}, policy, undefined, undefined, undefined, true);
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.ADD_EXPENSE)).toBe(true);
});

Expand Down