Repository navigation
fix: Move actions of receipt modal out of three dot overflow - #62025
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-23.at.22.46.09.android.movAndroid: mWeb ChromeScreen.Recording.2025-05-23.at.22.48.31.android.chrome.moviOS: HybridAppScreen.Recording.2025-05-23.at.22.52.02.ios.moviOS: mWeb SafariScreen.Recording.2025-05-23.at.22.49.16.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2025-05-23.at.22.41.45.web.movMacOS: DesktopScreen.Recording.2025-05-23.at.22.44.33.desktop.mov |
|
I am working on it |
|
@hoangzinh I just updated the PR to address your three comments above |
| return threeDotsMenuItems.length === 1 && shouldMinimizeMenuButton ? ( | ||
| <Tooltip text={threeDotsMenuItems.at(0)?.text}> | ||
| <PressableWithoutFeedback | ||
| onPress={threeDotsMenuItems.at(0)?.onSelected} |
There was a problem hiding this comment.
| onPress={threeDotsMenuItems.at(0)?.onSelected} | |
| onPress={threeDotsMenuItems.at(0).onSelected} |
| onPress={threeDotsMenuItems.at(0)?.onSelected} | ||
| style={[styles.touchableButtonImage]} | ||
| role={CONST.ROLE.BUTTON} | ||
| accessibilityLabel={threeDotsMenuItems.at(0)?.text ?? ''} |
There was a problem hiding this comment.
| accessibilityLabel={threeDotsMenuItems.at(0)?.text ?? ''} | |
| accessibilityLabel={threeDotsMenuItems.at(0).text ?? ''} |
| accessibilityLabel={threeDotsMenuItems.at(0)?.text ?? ''} | ||
| > | ||
| <Icon | ||
| src={firstMenuButton?.icon as React.FC<SvgProps>} |
There was a problem hiding this comment.
| src={firstMenuButton?.icon as React.FC<SvgProps>} | |
| src={threeDotsMenuItems.at(0).icon as React.FC<SvgProps>} |
| /** The URL link associated with the attachment's subtitle, if available */ | ||
| subTitleLink?: string; | ||
|
|
||
| /** If true, display the option directly instead of showing the menu button */ |
There was a problem hiding this comment.
| /** If true, display the option directly instead of showing the menu button */ | |
| /** If true, display the individual button instead of the three-dot menu when there's only one menu item */ |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/9)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/9)Meaningless Changes To Duration (1/8)Show entries
Show details
|
Performance Comparison Report 📊 (3/9)Meaningless Changes To Duration (2/8)Show entries
Show details
|
Performance Comparison Report 📊 (4/9)Meaningless Changes To Duration (3/8)Show entries
Show details
|
Performance Comparison Report 📊 (5/9)Meaningless Changes To Duration (4/8)Show entries
Show details
|
Performance Comparison Report 📊 (6/9)Meaningless Changes To Duration (5/8)Show entries
Show details
|
Performance Comparison Report 📊 (7/9)Meaningless Changes To Duration (6/8)Show entries
Show details
|
Performance Comparison Report 📊 (8/9)Meaningless Changes To Duration (7/8)Show entries
Show details
|
Performance Comparison Report 📊 (9/9)Meaningless Changes To Duration (8/8)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.54-0 🚀
|
|
I don't think this PR will cause a perf regression. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀
|

Explanation of Change
Fixed Issues
$ #61172
PROPOSAL: #61172 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
output.mp4
Android: mWeb Chrome
output.mp4
iOS: Native
output.mp4
iOS: mWeb Safari
Screen.Recording.2025-05-14.at.21.53.23.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-14.at.21.37.39.mov
MacOS: Desktop
Screen.Recording.2025-05-14.at.21.41.53.mov