Repository navigation
fix: IOU report cannot be moved to workspace #63011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8132b70
fix: IOU report cannot be moved to workspace
nkdengineer d7e7be1
Merge branch 'main' into fix/61982
nkdengineer 8f9facf
fix isAdmin condition
nkdengineer b7b496f
Merge branch 'main' into fix/61982
nkdengineer 7b3ecad
fix lint
nkdengineer 9ad6385
Merge branch 'main' into fix/61982
nkdengineer a42a5ae
update multiple expense case
nkdengineer 56f3526
disable lint rule
nkdengineer be1e95c
split iou report case
nkdengineer a003bb7
Update src/libs/ReportUtils.ts
nkdengineer 68fa292
Update src/libs/ReportUtils.ts
nkdengineer d4093c8
Update src/libs/ReportUtils.ts
nkdengineer 5bdd048
Update src/libs/ReportUtils.ts
nkdengineer f059414
Merge branch 'main' into fix/61982
nkdengineer 9cc5de9
edit comment
nkdengineer cd91e6d
resolve conflict
nkdengineer 11b5cce
merge main
nkdengineer 1b40357
fix test
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI
isWorkspaceEligibleForReportChangeis supposed to check if the user has access to a paid policy. We have a separate methodcanEditReportPolicythat I think this logic is better suited for