Repository navigation
Create new action for welcome whisper in new expense chat - #64187
Conversation
|
@puneetlath this one is ready to review too, we can merge once Auth is deployed. |
|
Asked for a review and test drive from a C+ here: https://expensify.slack.com/archives/C02NK2DQWUX/p1750720208260429 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Desktop |
dominictb
left a comment
There was a problem hiding this comment.
I tested the invite members, bottom up and move IOU to workspace flows and they all worked well.
![]()
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @dominictb, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #64834. |
|
Removing @tylerkaraszewski as a reviewer since I think @puneetlath will give the final review now that it's been C+ approved. |
|
@puneetlath Can we merge this? Are we still holding on BE? |
|
It's on hold. @carlosmiceli can we un-hold yet? |
|
Oops, hold removed, merged! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.72-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.1.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀
|




Explanation of Change
1- Making the whisper welcome message a unique reportAction which will be omitted when checking for activity in an expense chat.
2- Setting the visibility hidden for everyone but the submitter optimistically as well to avoid seeing it in the LHN before onyx updates.
(Holding on Auth's PR)
Fixed Issues
https://github.com/Expensify/Expensify/issues/489564
Tests
1- Create a workspace
2- Invite a member to the workspace
3- Confirm that the expense chat does NOT appear in the admin's LHN
4- Sign in as the invitee and confirm the expense chat appears in the LHN
5- Open the expense chat and confirm that there's a welcome message by the admin
6- Leave a comment in the expense chat
7- Sign in again as the admin and confirm that the invitee's expense chat now does appear in the LHN
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop