Repository navigation
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Yeah, I am having no luck replicating the NaN issue |
|
@parasharrajat if you could fix the conflict 🙏 |
…ert-63853-parasharrajat/travel-update
|
Done @rlinoz |
|
@rlinoz just wanna confirm if we still need to wait for something else here, don't we? |
|
No, I think we are good. The backend PR is deployed so |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-06-18.at.23.32.05.android.movAndroid: mWeb ChromeScreen.Recording.2025-06-18.at.23.34.15.android.chrome.moviOS: HybridAppScreen.Recording.2025-06-18.at.23.37.20.moviOS: mWeb SafariScreen.Recording.2025-06-18.at.23.19.32.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2025-06-18.at.23.12.13.web.movMacOS: DesktopScreen.Recording.2025-06-18.at.23.15.29.desktop.mov |
hoangzinh
left a comment
There was a problem hiding this comment.
LGTM. Tested again on Web
Screen.Recording.2025-06-27.at.14.52.17.mov
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.72-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀
|
| pnrData.travelerInfos.forEach((travelerInfo) => { | ||
| travelerInfo.tickets.forEach((ticket) => { | ||
| const flightCoupons = ticket.flightCoupons; | ||
| flightCoupons.forEach((flightDetails, index) => { |
There was a problem hiding this comment.
Coming from #72494, it should be sorted by legIdx because the array order can be wrong
Explanation of Change
Fixed Issues
$ #63256
PROPOSAL:
Tests
Offline tests
You can't book travel offline.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
18.06.2025_02.24.35_REC.mp4
Android: mWeb Chrome
18.06.2025_02.18.31_REC.mp4
iOS: Native
18.06.2025_02.19.37_REC.mp4
iOS: mWeb Safari
18.06.2025_02.16.24_REC.mp4
MacOS: Chrome / Safari
18.06.2025_02.06.57_REC.mp4
MacOS: Desktop
18.06.2025_02.23.57_REC.mp4