Repository navigation
Fix RECEIPT_NOT_SMART_SCANNED violation visibility across Report Preview, LHN, and Search #70507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
blimpich
merged 15 commits into
Expensify:main
from
abzokhattab:fix/receipt-not-smart-scanned-violation-visibility
Oct 13, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c3fae90
Fix RECEIPT_NOT_SMART_SCANNED violation visibility across Report Prev…
abzokhattab 6456973
fix double import
abzokhattab 8455914
fixing ts types
abzokhattab 3577859
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab a84ffcc
fixing failing tests
abzokhattab fe2642e
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab a10be7d
fixing imports
abzokhattab 02b3831
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab 33d5a6a
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab f3e5f5b
Filter transaction violations based on user visibility rules
abzokhattab 0bea67f
adding function comments to hasVisibleViolationsForUser
abzokhattab 20f4721
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab 235ff86
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab e7df872
Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…
abzokhattab 3560612
Add test coverage for violation filtering
abzokhattab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: What do you think about adding a comment to the function? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done