Repository navigation
Navigation initialization console errors fix #71367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pecanoro
merged 20 commits into
Expensify:main
from
software-mansion-labs:collectioneur/fix-navigation-console-errors
Oct 7, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
71b90a8
fixed all console errors related to navigation initialization
collectioneur 3893b2f
small cleanup
collectioneur 255dc91
changed to eraly returns
collectioneur 227c2b1
Merge branch 'main' into collectioneur/fix-navigation-console-errors
collectioneur bde4161
Merge branch 'main' into collectioneur/fix-navigation-console-errors
collectioneur 31c1fcd
testing why tests are broken
collectioneur cc09dba
trying to avoid typecheck errors
collectioneur a558bdf
fixed tests
collectioneur bd5f272
added logs and empty state
collectioneur a3ba7dd
add names
collectioneur f5704cb
small fix
collectioneur 9d239ed
small fix in log
collectioneur 47432f2
Merge branch 'main' into collectioneur/fix-navigation-console-errors
collectioneur 91bc8ba
changed the logic of handling navigationRef errors to simulate logic …
collectioneur aa05cbf
removed unneccessary test fixes
collectioneur 1a3b898
safe handling when navigation isn't yet initialized
collectioneur 5cf2119
changed to early return when handling undefined state in navigateWork…
collectioneur 3e37214
changed early return value to false when state is not initialized
collectioneur b58a588
Merge branch 'main' into collectioneur/fix-navigation-console-errors
collectioneur 89b57a8
added undefined state handling after merge
collectioneur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 9 additions & 3 deletions
12
src/libs/Navigation/helpers/isOnSearchMoneyRequestReportPage.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.