Repository navigation
[No QA] perf: production bundle cleanup - #71646
roryabraham merged 8 commits into
Conversation
|
|
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| "babel-loader": "^9.1.3", | ||
| "babel-plugin-module-resolver": "^5.0.0", | ||
| "babel-plugin-react-compiler": "^19.0.0-beta-8a03594-20241020", | ||
| "babel-plugin-react-compiler": "^19.0.0-beta-ebf51a3-20250411", |
There was a problem hiding this comment.
I think this i unrelated to this PR, right?
There was a problem hiding this comment.
It is related, without updating this after changing target from 18 to 19 in ReactCompilerConfig tests were running 2-3 times longer in some cases, this version is last beta.
| "compress-svg": "npx ts-node scripts/compressSvg.ts --dir assets/images" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/runtime": "^7.25.0", |
There was a problem hiding this comment.
Is this supposed be in deps?
There was a problem hiding this comment.
I moved it here mainly to silence the warning about this package being included in the production bundle. According to the docs, it should normally be listed under dependencies: https://babeljs.io/docs/babel-runtime#installation
| "react-dom": "19.0.0", | ||
| "react-error-boundary": "^4.0.11", | ||
| "react-fast-pdf": "^1.0.29", | ||
| "react-is": "^18.3.1", |
There was a problem hiding this comment.
Do we need to move react-is from devDependencies to dependencies?
There was a problem hiding this comment.
I moved it under dependencies to better emphasize that the application won’t work when it’s built without it. More details here: #71215 (comment)
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb Chromemweb-chrome.moviOS: HybridAppiOS.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
|
||
| const ReactCompilerConfig = { | ||
| target: '18', | ||
| target: '19', |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.28-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀
|
Explanation of Change
Fixed Issues
$ #71215
PROPOSAL: https://expensify.slack.com/archives/C08CZDJFJ77/p1758704756163939
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop