Repository navigation
Invisible report is created after submit scan expense from self DM to workspace chat #72179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chuckdries
merged 7 commits into
Expensify:main
from
thelullabyy:fix/70744-invisible-report-created-after-submit-scan-expense
Oct 13, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e0d031
fix: invisible report is created after submit scan expense from self DM
thelullabyy de587df
update code
thelullabyy ee6902f
Merge branch 'Expensify:main' into fix/70744-invisible-report-created…
thelullabyy b2b59fe
Merge branch 'main' into fix/70744-invisible-report-created-after-sub…
thelullabyy 7a05ce6
update comment
thelullabyy ddfbc9a
update
thelullabyy b076de5
Merge branch 'main' into fix/70744-invisible-report-created-after-sub…
thelullabyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a bullet to the comment above explaining why we don't create a new money request report for submit actions specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chuckdries I think it would be best to check with the internal team about the logic for when a new money request report should be created. Once we have clarity, we can document all the relevant cases directly in a comment on the
shouldCreateNewMoneyRequestReportfunction—rather than only explaining why we don’t create a new report for submit actions specifically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused at what you mean. There already is a comment on
shouldCreateNewMoneyRequestReportthat explains when a new money request report should be created. I'm just saying it'd be helpful to add to it a note about why we're adding an exception forsubmitactions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chuckdries I updated the comment to more clearly. Please help to check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thelullabyy, sorry to be so pedantic about this - I should've been more clear from the get-go. Can you please put in the comment why we're excluding
submitactions specifically. Just briefly describe what the bug that we're solving is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chuckdries In the comment I added to the function:
I was simply highlighting that we create a new report only if the action is not
"submit". However, as you pointed out, I wasn’t able to provide a clear explanation for why we don’t create a report when the action is"submit".The reason I included the
action !== CONST.IOU.ACTION.SUBMITcondition was purely to align with the current backend behavior.If we need a definitive explanation for why a report isn't created in the
"submit"case, we should probably reach out to the backend or internal team for clarification.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous comment we added here:
App/src/libs/ReportUtils.ts
Line 10140 in 35e6f75
—it simply notes that when the it is waiting on the payee to add a bank account, we create a new report. However, it doesn't explain why that behavior is necessary in this case.