Repository navigation
Disable Categorize it and Share with my accountant options when tracking expenses #72555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -44,10 +44,6 @@ describe('ReportDetailsPage', () => { | |||||
| }); | ||||||
|
|
||||||
| it('self DM track options should disappear when report moved to workspace', async () => { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, as the track flow is temporarily disabled, instead of removing tests, maybe we can disable this test temporarily as well? So we can enable it again in the future
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this test still makes sense for the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, instead of disabling the whole test, comment lines also makes sense to me |
||||||
| await act(async () => { | ||||||
| await Onyx.merge(ONYXKEYS.BETAS, [CONST.BETAS.TRACK_FLOWS]); | ||||||
| }); | ||||||
|
|
||||||
| const selfDMReportID = '1'; | ||||||
| const trackExpenseReportID = '2'; | ||||||
| const trackExpenseActionID = '123'; | ||||||
|
|
@@ -95,12 +91,13 @@ describe('ReportDetailsPage', () => { | |||||
| await waitForBatchedUpdatesWithAct(); | ||||||
|
|
||||||
| const submitText = translateLocal('actionableMentionTrackExpense.submit'); | ||||||
| const categorizeText = translateLocal('actionableMentionTrackExpense.categorize'); | ||||||
| const shareText = translateLocal('actionableMentionTrackExpense.share'); | ||||||
|
|
||||||
| await screen.findByText(submitText); | ||||||
| await screen.findByText(categorizeText); | ||||||
| await screen.findByText(shareText); | ||||||
|
|
||||||
| // Categorize and share are temporarily disabled | ||||||
| // const categorizeText = translateLocal('actionableMentionTrackExpense.categorize'); | ||||||
| // const shareText = translateLocal('actionableMentionTrackExpense.share'); | ||||||
| // await screen.findByText(categorizeText); | ||||||
| // await screen.findByText(shareText); | ||||||
|
|
||||||
| const movedTrackExpenseReport = { | ||||||
| ...trackExpenseReport, | ||||||
|
|
@@ -128,7 +125,9 @@ describe('ReportDetailsPage', () => { | |||||
| ); | ||||||
|
|
||||||
| expect(screen.queryByText(submitText)).not.toBeVisible(); | ||||||
| expect(screen.queryByText(categorizeText)).not.toBeVisible(); | ||||||
| expect(screen.queryByText(shareText)).not.toBeVisible(); | ||||||
|
|
||||||
| // Categorize and share are temporarily disabled | ||||||
| // expect(screen.queryByText(categorizeText)).not.toBeVisible(); | ||||||
| // expect(screen.queryByText(shareText)).not.toBeVisible(); | ||||||
| }); | ||||||
| }); | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for next time: explain why and until when it's supposed to be temporarily disabled.
And also ideally explain in the PR description 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang, thanks a lot for flagging this, I completely missed it! 🤦♂️
I’ve updated the PR description to add more context. Do you think it would also make sense to open a follow-up PR to include links to the discussions directly in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine with the context from the PR description now, thanks for adding it.