Skip to content

[No QA] Create special-feeds.md - #72660

Merged
johncschuster merged 3 commits into
mainfrom
RachCHopkins-patch-3
Oct 15, 2025
Merged

johncschuster merged 3 commits into
mainfrom
RachCHopkins-patch-3

Conversation

@RachCHopkins

Copy link
Copy Markdown
Contributor

Explanation of Change

New help doc to:

  • Inform of special feeds
  • Add back deleted ANZ bank content
  • Add new Brex feed info

Fixed Issues

https://github.com/Expensify/Expensify/issues/538217

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@RachCHopkins RachCHopkins self-assigned this Oct 15, 2025
@RachCHopkins
RachCHopkins requested a review from a team as a code owner October 15, 2025 06:30
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@melvin-bot
melvin-bot Bot requested review from johncschuster and removed request for a team October 15, 2025 06:30
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new comprehensive documentation file for special bank feeds in Expensify Classic. The document effectively consolidates information about non-standard feed formats and provides specific setup instructions for complex integrations.

Scores Summary

  • Readability: 8/10 - Well-structured content with clear sections and step-by-step instructions
  • AI Readiness: 9/10 - Excellent metadata, descriptive headings, and comprehensive keywords
  • Style Compliance: 8/10 - Follows Expensify documentation standards with minor formatting opportunities

Key Findings

Strengths:

  • Comprehensive YAML metadata with excellent keyword coverage
  • Clear hierarchical structure with descriptive headings
  • Well-organized content flow from general to specific information
  • Practical step-by-step instructions for complex processes
  • Proper use of formatting (bold text, numbered lists, bullets)
  • Good context setting with timeline expectations (more than a month to enable)

Areas for Improvement:

  • Minor formatting inconsistency with trailing spaces after bullet points
  • The ANZ section title could be more specific (ANZ Visa New Zealand vs just location)
  • Some technical jargon (CDF, VCF, SDF) could benefit from brief explanations
  • The HR integration section could use clearer prerequisites

Recommendations

  1. Remove trailing spaces after bullet points in the supported feeds list for cleaner formatting
  2. Consider adding brief explanations for technical acronyms (CDF = Common Data File, VCF = Visa Card File, etc.) in parentheses on first use
  3. Enhance the HR integration prerequisites by clearly stating what HR systems are supported
  4. Add estimated timelines for ANZ and Brex setup processes to match the general guidance

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/special-feeds.md - New comprehensive documentation covering special feeds, HR integrations, and specific setup instructions for ANZ and Brex feeds

Overall Impact: This documentation significantly improves user guidance for complex feed setups that were previously undocumented or scattered. The content addresses real user needs and provides actionable instructions for technical processes.

Recommendation: Approve with minor formatting cleanup suggested above.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR creates a new help document for special bank feeds in Expensify Classic, consolidating information about non-standard feed formats, HR integrations for card auto-assignment, and specific setup instructions for ANZ and Brex feeds. The documentation serves as a centralized resource for users dealing with complex banking integrations.

Scores Summary

  • Readability: 8/10 - Clear, well-structured content with logical flow and appropriate formatting
  • AI Readiness: 9/10 - Excellent descriptive headings, proper YAML metadata, and clear context throughout
  • Style Compliance: 8/10 - Good adherence to Expensify voice with minor terminology considerations

Key Findings

Strengths:

  • Comprehensive YAML metadata with descriptive title and relevant keywords
  • Clear hierarchical structure using proper heading levels (# and ## only)
  • Logical organization from general to specific information
  • Step-by-step instructions that are easy to follow
  • Proper use of formatting elements (numbered lists, bullet points, bold text)
  • Good use of notes and warnings to highlight important information

Areas for Improvement:

  • Some inconsistent spacing around bullet points in the supported feeds list
  • Could benefit from more specific timeline expectations beyond "more than a month"
  • The HR integration section could be clearer about prerequisites

Recommendations

Priority Actions:

  1. Consider adding estimated timeline ranges for different feed types to set better expectations
  2. Add cross-references to related help articles (e.g., API documentation, standard card feeds)
  3. Consider adding a troubleshooting section for common setup issues

Style Enhancements:

  1. Ensure consistent spacing in bulleted lists throughout the document
  2. Consider adding more context about what CDF, VCF, and other acronyms mean for first-time users
  3. Add links to relevant Expensify Classic sections where appropriate

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/special-feeds.md - New comprehensive guide covering special bank feeds, HR integrations, and specific setup instructions for ANZ and Brex

Overall Quality Score: 8.5/10 - This is a well-crafted documentation piece that effectively consolidates complex information into a user-friendly format. The structure is sound, the content is comprehensive, and it follows HelpDot standards well. Minor improvements in consistency and cross-referencing would elevate this to excellent quality.

The document successfully addresses the need for centralized information about special feeds while maintaining clarity and actionability for users dealing with these complex integrations.

@OSBotify

OSBotify commented Oct 15, 2025 •

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://cff90f86.helpdot.pages.dev ⚡️

Updated articles:

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new comprehensive help document for special credit card feeds in Expensify Classic. The document consolidates information about non-standard feed formats, HR integrations for card auto-assignment, and specific setup instructions for ANZ and Brex feeds. The content addresses a clear documentation gap by providing centralized guidance for complex feed setups that require engineering coordination.

Scores Summary

  • Readability: 8/10 - Well-structured content with clear sections and logical flow. Language is accessible and technical concepts are explained appropriately.
  • AI Readiness: 7/10 - Good use of descriptive headings and structured content, though some sections could benefit from more explicit context and standardized formatting.
  • Style Compliance: 6/10 - Generally follows HelpDot standards but has some inconsistencies in formatting, terminology, and structure that need addressing.

Key Findings

Strengths:

  • Comprehensive Coverage: Successfully consolidates scattered information about special feeds into one accessible location
  • Practical Focus: Includes actionable setup instructions for ANZ and Brex feeds with clear step-by-step processes
  • Technical Depth: Appropriately balances technical detail with user-friendly explanations
  • Clear Organization: Logical section structure that flows from general concepts to specific implementations

Areas for Improvement:

  • Metadata Completeness: Missing required YAML frontmatter fields (permalink, redirects)
  • Formatting Inconsistencies: Mix of list styles and inconsistent spacing throughout
  • Terminology Alignment: Some terms don't align with standard Expensify vocabulary
  • Context Dependencies: Several sections assume knowledge that may not be available to all readers

Recommendations

Priority 1 - Critical:

  1. Add Complete YAML Frontmatter: Include permalink and redirects fields to ensure proper site integration
  2. Standardize List Formatting: Use consistent bullet style (- vs •) and proper spacing throughout
  3. Verify Technical Accuracy: Ensure all feed format names and setup processes are current and accurate

Priority 2 - Important:
4. Enhance Context: Add more explicit explanations for technical terms like "CDF", "VCF", and "Domain ID"
5. Improve Navigation: Consider adding internal links between related sections
6. Align Terminology: Use "workspace" consistently instead of mixing with other terms

Priority 3 - Polish:
7. Expand Examples: Add more specific examples or screenshots where helpful
8. Consider FAQ Section: Common questions about special feeds could be addressed proactively

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/special-feeds.md - New comprehensive document covering special feed types, HR integrations, and specific setup instructions for ANZ and Brex feeds. Generally well-structured with good technical content, but needs formatting standardization and metadata completion.

Note: This is a new file addition that fills an important documentation gap. With the recommended improvements, this will be a valuable resource for users dealing with complex feed setups.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR introduces a new help document for Special Feeds in Expensify Classic. The content addresses specific banking feed types, HR integration capabilities, and setup instructions for ANZ and Brex feeds. While the document provides valuable technical information, there are several areas where it could be improved to meet HelpDot documentation standards.

Scores Summary

  • Readability: 7/10 - Clear structure and good use of formatting, but some sections could benefit from better organization and more detailed explanations
  • AI Readiness: 6/10 - Missing key structural elements like breadcrumbs, inconsistent heading hierarchy, and could benefit from more descriptive headings
  • Style Compliance: 6/10 - Follows basic markdown conventions but doesn't align with the established HelpDot template structure and voice

Key Findings

Positive Aspects:

  • Comprehensive coverage of supported special feeds with a well-organized list
  • Clear step-by-step instructions for ANZ and Brex setup processes
  • Good use of markdown formatting for lists and emphasis
  • Practical information about timing expectations and coordination requirements
  • Proper YAML frontmatter with title, description, and keywords

Areas for Improvement:

  • Document structure doesn't follow the established HelpDot template (Overview → How-to → Deep Dive → FAQ)
  • Missing user-focused sections like "Main Uses," "Core Users," and "Advantages"
  • Some technical jargon (CDF, VCF, API) used without sufficient context or explanation
  • Inconsistent heading hierarchy (uses # and ## but jumps levels)
  • No FAQ section despite complex technical content that would benefit from common questions

Recommendations

High Priority:

  1. Restructure according to HelpDot template: Add Overview, Main Uses, Core Users, and Advantages sections
  2. Improve heading hierarchy: Use consistent # for main sections, ## for subsections
  3. Add FAQ section: Include common questions about setup timelines, troubleshooting, and requirements
  4. Clarify technical terms: Provide brief explanations for acronyms like CDF, VCF, API on first use

Medium Priority:

  1. Enhance user context: Add information about who needs this feature and why
  2. Improve readability: Break up longer paragraphs and add more white space
  3. Add troubleshooting guidance: Include common issues and solutions for special feeds
  4. Consider visual elements: Evaluate if diagrams or screenshots would improve understanding

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/special-feeds.md - New comprehensive guide covering special banking feeds, requires structural improvements to meet HelpDot standards

Note: This document provides valuable technical information but would benefit from restructuring to follow established HelpDot patterns and improve user accessibility. The content is solid but needs better organization and context for end users.

@RachCHopkins

Copy link
Copy Markdown
Contributor Author

I don't understand where all these AI suggestions are coming from. Half of this was written by AI, then reviewed by AI, now we have more AI arguing with the first AI.

@RachCHopkins

Copy link
Copy Markdown
Contributor Author

Note: This document provides valuable technical information but would benefit from restructuring to follow established HelpDot patterns and improve user accessibility. The content is solid but needs better organization and context for end users.

Note: We absolutely do not want customers doing anything here themselves except for the ANZ feeds, and this is the content we already had, which has since been reviewed and rewritten by AI already. We want them to ask their AM for help. This is not a DIY help doc.

@johncschuster johncschuster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johncschuster
johncschuster merged commit 773f8a2 into main Oct 15, 2025
2 checks passed
@johncschuster
johncschuster deleted the RachCHopkins-patch-3 branch October 15, 2025 23:08
@melvin-bot melvin-bot Bot added the Emergency label Oct 15, 2025
@melvin-bot

melvin-bot Bot commented Oct 15, 2025

Copy link
Copy Markdown

@johncschuster looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify OSBotify mentioned this pull request Oct 16, 2025
67 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/johncschuster in version: 9.2.33-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants