Repository navigation
[No QA] Create special-feeds.md - #72660
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new comprehensive documentation file for special bank feeds in Expensify Classic. The document effectively consolidates information about non-standard feed formats and provides specific setup instructions for complex integrations. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
Recommendations
Files Reviewed
Overall Impact: This documentation significantly improves user guidance for complex feed setups that were previously undocumented or scattered. The content addresses real user needs and provides actionable instructions for technical processes. Recommendation: Approve with minor formatting cleanup suggested above. |
HelpDot Documentation ReviewOverall AssessmentThis PR creates a new help document for special bank feeds in Expensify Classic, consolidating information about non-standard feed formats, HR integrations for card auto-assignment, and specific setup instructions for ANZ and Brex feeds. The documentation serves as a centralized resource for users dealing with complex banking integrations. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority Actions:
Style Enhancements:
Files Reviewed
Overall Quality Score: 8.5/10 - This is a well-crafted documentation piece that effectively consolidates complex information into a user-friendly format. The structure is sound, the content is comprehensive, and it follows HelpDot standards well. Minor improvements in consistency and cross-referencing would elevate this to excellent quality. The document successfully addresses the need for centralized information about special feeds while maintaining clarity and actionability for users dealing with these complex integrations. |
|
A preview of your ExpensifyHelp changes have been deployed to https://cff90f86.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new comprehensive help document for special credit card feeds in Expensify Classic. The document consolidates information about non-standard feed formats, HR integrations for card auto-assignment, and specific setup instructions for ANZ and Brex feeds. The content addresses a clear documentation gap by providing centralized guidance for complex feed setups that require engineering coordination. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority 1 - Critical:
Priority 2 - Important: Priority 3 - Polish: Files Reviewed
Note: This is a new file addition that fills an important documentation gap. With the recommended improvements, this will be a valuable resource for users dealing with complex feed setups. |
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new help document for Special Feeds in Expensify Classic. The content addresses specific banking feed types, HR integration capabilities, and setup instructions for ANZ and Brex feeds. While the document provides valuable technical information, there are several areas where it could be improved to meet HelpDot documentation standards. Scores Summary
Key FindingsPositive Aspects:
Areas for Improvement:
RecommendationsHigh Priority:
Medium Priority:
Files Reviewed
Note: This document provides valuable technical information but would benefit from restructuring to follow established HelpDot patterns and improve user accessibility. The content is solid but needs better organization and context for end users. |
|
I don't understand where all these AI suggestions are coming from. Half of this was written by AI, then reviewed by AI, now we have more AI arguing with the first AI. |
Note: We absolutely do not want customers doing anything here themselves except for the ANZ feeds, and this is the content we already had, which has since been reviewed and rewritten by AI already. We want them to ask their AM for help. This is not a DIY help doc. |
|
@johncschuster looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.2.33-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀
|
Explanation of Change
New help doc to:
Fixed Issues
https://github.com/Expensify/Expensify/issues/538217
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.