Repository navigation
Conversation
Codecov Report❌ Patch coverage is
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| initiallyFocusedOptionKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG} | ||
| initiallyFocusedItemKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG} | ||
| shouldSingleExecuteRowSelect | ||
| shouldUpdateFocusedIndex |
There was a problem hiding this comment.
Same here, could you check if this prop is needed? I wouldn't say so if clicking list item automatically leave the page
There was a problem hiding this comment.
Here we need this prop. In this case clicking the item doesn't leave the page
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-24.at.09.44.46.movAndroid: mWeb ChromeScreen.Recording.2025-10-24.at.09.42.20.moviOS: HybridAppScreen.Recording.2025-10-24.at.09.45.18.moviOS: mWeb SafariScreen.Recording.2025-10-24.at.09.41.35.movMacOS: Chrome / SafariScreen.Recording.2025-10-24.at.09.36.41.movMacOS: DesktopScreen.Recording.2025-10-24.at.09.46.19.mov |
grgia
left a comment
There was a problem hiding this comment.
@OlGierd03 would you merge main for validate actions
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.39-3 🚀
|
Explanation of Change
Fixed Issues
$ #65655
Tests
WorkspacestabMore featuresand enable theAccountingtoggleAccountingtabNetSuiteaccounting system to the workspaceAccounting>Import>Custom Segments/recordsAdd custom segment/recordNetSuiteCustomSegmentMappingPickeris working correctlyOffline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
web_android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
web_ios.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov