Repository navigation
[CP staging] Revert "Merge pull request #65776 from nabi-ebrahimi/fix/chat-infinite-loading-on-removed-member - #73764
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| currentReportIDFormRoute, | ||
| reportIdRef.current, | ||
| ], | ||
| [firstRender, shouldShowNotFoundLinkedAction, reportID, isOptimisticDelete, reportMetadata?.isLoadingInitialReportActions, userLeavingStatus, currentReportIDFormRoute], |
There was a problem hiding this comment.
❌ PERF-6 (docs)
The useMemo dependency array includes firstRender but the condition uses firstRenderRef.current. This creates unnecessary re-computations when firstRender changes, even though the actual logic depends on the ref value.
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
[firstRenderRef.current, shouldShowNotFoundLinkedAction, reportID, isOptimisticDelete, reportMetadata?.isLoadingInitialReportActions, userLeavingStatus, currentReportIDFormRoute],|
@amyevans looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not an emergency, straight revert |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.40-1 🚀
|
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.40-1 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.40-1 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀
|
This reverts commit 758609d, reversing changes made to b7b20a8.
Explanation of Change
Straight revert of #65776
Fixed Issues
$ #73715
PROPOSAL: N/A
Tests
Precondition:
Use new account for User A and User B.
User A and User B have not talked to each other.
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
fixed-on-revert.mov
MacOS: Desktop