Repository navigation
fix for not showing flip to negative value for the new sign ups - #73827
Conversation
…rst-time submissions
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ZhenjaHorbach I think we can skip fixing the lint here, as its about removing |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-11-03.11.23.01.movAndroid: mWeb Chrome2025-11-03.11.20.53.moviOS: HybridApp2025-11-03.11.03.48.moviOS: mWeb Safari2025-11-03.11.03.48.movMacOS: Chrome / Safari2025-11-03.11.01.53.movMacOS: Desktop2025-11-03.11.01.53.mov |
|
Actually, do we really need a flip button for all cases after creating a new account? CC:@mountiny 2025-11-03.10.55.11.mov |
But from another side |
We will soon start creating the selfDM for everyone so the tracked options should sort of be available always |
|
But yeah I think the case of no workspace and no selfDM locally should be handled as otherwise the user is pushed to dead end |
This is where my head went first too.
But yes, I agree we should probably avoid getting into this weird spot. 👍 |
|
Alright so should we handle that here? I believe the command that will unreport the expense can create the selfDM optimistically so I guess the solution would be to show that option even if the selfDM report is not available locally? |
|
@ZhenjaHorbach Can you create GH issue? Could you create one with the steps for the issue you found? |
|
Sure |
|
@kubabutkiewicz can you fix the eslint please? |
|
|
LGTM! |
|
|
||
| return ( | ||
| (isExpenseReport(report) || isGroupPolicy(policy?.type ?? '') || isSelfDMReport || iouType === CONST.IOU.TYPE.CREATE) && | ||
| (isExpenseReport(report) || isGroupPolicy(policy?.type ?? '') || isSelfDMReport || iouType === CONST.IOU.TYPE.CREATE || isFirstTimeCreatingReport) && |
There was a problem hiding this comment.
this block is a bit unclear to read, can we add a function or variable to make it clear what these checks mean?
|
Failing tests don't look like related to my changes 🤔 |
trjExpensify
left a comment
There was a problem hiding this comment.
Good from product 👍
|
@grgia |
mountiny
left a comment
There was a problem hiding this comment.
Thanks, I am following up on the issue you have created @ZhenjaHorbach
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.55-3 🚀
|
|
@kubabutkiewicz Hello |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.57-0 🚀
|
|
@mountiny @grgia Can you help with this?
|
|
@lanitochka17 yes flip button only appears when we are displaying big num pad |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|

Explanation of Change
Fixed Issues
$#72616
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop