Skip to content

fix for not showing flip to negative value for the new sign ups - #73827

Merged
mountiny merged 3 commits into
Expensify:mainfrom
callstack-internal:fix-72616
Nov 11, 2025
Merged

mountiny merged 3 commits into
Expensify:mainfrom
callstack-internal:fix-72616

Conversation

@kubabutkiewicz

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$#72616
PROPOSAL:

Tests

  1. Sign up to new account
  2. Click on FAB -> Create Expense
  3. Switch to Manual
  4. Verify that button to Flip to negative value is visible
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native image
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@kubabutkiewicz
kubabutkiewicz requested a review from a team as a code owner October 30, 2025 11:11
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team October 30, 2025 11:11
@melvin-bot

melvin-bot Bot commented Oct 30, 2025

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Oct 30, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ReportUtils.ts 75.08% <50.00%> (+0.01%) ⬆️
... and 11 files with indirect coverage changes

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach I think we can skip fixing the lint here, as its about removing runAfterInteractions from ReportUtils, which is used in the onyx.connect which will be removed during onyx.connect deprecation project

@ZhenjaHorbach

ZhenjaHorbach commented Nov 3, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2025-11-03.11.23.01.mov
Android: mWeb Chrome
2025-11-03.11.20.53.mov
iOS: HybridApp
2025-11-03.11.03.48.mov
iOS: mWeb Safari
2025-11-03.11.03.48.mov
MacOS: Chrome / Safari
2025-11-03.11.01.53.mov
MacOS: Desktop
2025-11-03.11.01.53.mov

@ZhenjaHorbach

ZhenjaHorbach commented Nov 3, 2025 •

Copy link
Copy Markdown
Contributor

Actually, do we really need a flip button for all cases after creating a new account?
For example, when we create a new account without selfDM and without a workspace
And when we try to use a negative value and then press Next
We can't choose or find anything
Because we can use negative values only with workspaces or selfDM (And Search in this case is useless)

CC:@mountiny

2025-11-03.10.55.11.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Actually, do we really need a flip button for all cases after creating a new account? For example, when we create a new account without selfDM and without a workspace And when we try to use a negative value and then press Next We can't choose or find anything Because we can use negative values only with workspaces or selfDM (And Search in this case is useless)

CC:@mountiny

But from another side
It looks like a separate issue
And overall, the changes look good!

@mountiny

mountiny commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

For example, when we create a new account without selfDM and without a workspace

We will soon start creating the selfDM for everyone so the tracked options should sort of be available always

@mountiny

mountiny commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

But yeah I think the case of no workspace and no selfDM locally should be handled as otherwise the user is pushed to dead end

@trjExpensify

Copy link
Copy Markdown
Contributor

We will soon start creating the selfDM for everyone so the tracked options should sort of be available always

This is where my head went first too.

But yeah I think the case of no workspace and no selfDM locally should be handled as otherwise the user is pushed to dead end

But yes, I agree we should probably avoid getting into this weird spot. 👍

@mountiny

mountiny commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Alright so should we handle that here? I believe the command that will unreport the expense can create the selfDM optimistically so I guess the solution would be to show that option even if the selfDM report is not available locally?

@mountiny

mountiny commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

@ZhenjaHorbach Can you create GH issue? Could you create one with the steps for the issue you found?

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Sure
I will create today or tomorrow

@mountiny

mountiny commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

@kubabutkiewicz can you fix the eslint please?

@ZhenjaHorbach

ZhenjaHorbach commented Nov 6, 2025 •

Copy link
Copy Markdown
Contributor

@mountiny
#74445
Created an issue
But what is expected behavior here?

@kubabutkiewicz

kubabutkiewicz commented Nov 6, 2025 •

Copy link
Copy Markdown
Contributor Author

@mountiny

@kubabutkiewicz can you fix the eslint please?

#73827 (comment)

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

LGTM!

@melvin-bot
melvin-bot Bot requested a review from grgia November 6, 2025 15:16
Comment thread src/libs/ReportUtils.ts Outdated

return (
(isExpenseReport(report) || isGroupPolicy(policy?.type ?? '') || isSelfDMReport || iouType === CONST.IOU.TYPE.CREATE) &&
(isExpenseReport(report) || isGroupPolicy(policy?.type ?? '') || isSelfDMReport || iouType === CONST.IOU.TYPE.CREATE || isFirstTimeCreatingReport) &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block is a bit unclear to read, can we add a function or variable to make it clear what these checks mean?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @grgia

@kubabutkiewicz
kubabutkiewicz requested a review from a team as a code owner November 7, 2025 15:23
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team November 7, 2025 15:23
@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

Failing tests don't look like related to my changes 🤔

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from product 👍

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@grgia
I suppose we can merge this PR 😅

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I am following up on the issue you have created @ZhenjaHorbach

@mountiny
mountiny merged commit b1e9aca into Expensify:main Nov 11, 2025
2 checks passed
@OSBotify OSBotify mentioned this pull request Nov 12, 2025
67 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.55-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@lanitochka17

lanitochka17 commented Nov 12, 2025 •

Copy link
Copy Markdown

@kubabutkiewicz Hello
Should this work for the Web?
Will flip button only appear for mweb, Android and iOS?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.57-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

Copy link
Copy Markdown

@mountiny @grgia Can you help with this?

@kubabutkiewicz Hello
Should this work for the Web?
Will flip button only appear for mweb, Android and iOS?

@kubabutkiewicz

Copy link
Copy Markdown
Contributor Author

@lanitochka17 yes flip button only appears when we are displaying big num pad
image
So not on web

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants