Skip to content

[No QA] Fix isActiveRoute flaky test #74164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MonilBhavsar merged 2 commits into from
Nov 4, 2025
Merged

[No QA] Fix isActiveRoute flaky test #74164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb1a4d5
Render navigation container once
MonilBhavsar Nov 4, 2025
8067d71
Fix lint
MonilBhavsar Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions tests/navigation/isActiveRouteTests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {describe, expect, test} from '@jest/globals';
import {describe, expect} from '@jest/globals';
import {render} from '@testing-library/react-native';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import getIsNarrowLayout from '@libs/getIsNarrowLayout';
Expand All @@ -23,18 +23,9 @@ describe('Navigation', () => {
mockedGetIsNarrowLayout.mockReturnValue(true);
mockedUseResponsiveLayout.mockReturnValue({...CONST.NAVIGATION_TESTS.DEFAULT_USE_RESPONSIVE_LAYOUT_VALUE, shouldUseNarrowLayout: true});
});
// given current active route is "/settings/profile?backTo=settings%2profile"
test.each([
['settings/profile' as Route, true],
['settings/profile/' as Route, true],
['settings/profile?param=1' as Route, true],
['settings/profile/display-name' as Route, false],
['settings/profile/display-name/' as Route, false],
['settings/preferences' as Route, false],
['report' as Route, false],
['report/123/' as Route, false],
['report/123' as Route, false],
])('isActiveRoute("%s") should return %s', (routeToCheck, expectedResult) => {

it('Should correctly identify active routes', () => {
// Given current active route is "/settings/profile?backTo=settings%2profile"
render(
<TestNavigationContainer
initialState={{
Expand All @@ -61,7 +52,16 @@ describe('Navigation', () => {
}}
/>,
);
const result = Navigation.isActiveRoute(routeToCheck);
expect(result).toBe(expectedResult);

expect(Navigation.isActiveRoute('settings/profile' as Route)).toBe(true);
expect(Navigation.isActiveRoute('settings/profile/' as Route)).toBe(true);
expect(Navigation.isActiveRoute('settings/profile?param=1' as Route)).toBe(true);
expect(Navigation.isActiveRoute('settings/profile/display-name' as Route)).toBe(false);
expect(Navigation.isActiveRoute('settings/profile/display-name/' as Route)).toBe(false);
expect(Navigation.isActiveRoute('settings/preferences' as Route)).toBe(false);
expect(Navigation.isActiveRoute('settings/preferences/' as Route)).toBe(false);
expect(Navigation.isActiveRoute('report' as Route)).toBe(false);
expect(Navigation.isActiveRoute('report/123/' as Route)).toBe(false);
expect(Navigation.isActiveRoute('report/123' as Route)).toBe(false);
Comment on lines +56 to +65

Copilot AI Nov 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidating multiple test cases into a single test block reduces test granularity and makes it harder to identify which specific route check fails. When one assertion fails, subsequent assertions won't run, and the test output won't clearly indicate which route caused the failure. Consider using test.each or separate test cases to maintain better test isolation and clearer failure reporting.

Copilot uses AI. Check for mistakes.

@MonilBhavsar MonilBhavsar Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error line would tell which assertion is failing, so it should be fine

});
});