Repository navigation
Don't allow uesr to make tag list required if it's not a multi level tag - #74198
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Patch coverage is
... and 19 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Asked for translation verification here: https://expensify.slack.com/archives/C01GTK53T8Q/p1762383509738459 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp74198_android_native.movAndroid: mWeb Chrome74198_android_web.moviOS: HybridApp74198_ios_native.moviOS: mWeb Safari74198_ios_web.movMacOS: Chrome / Safari74198_web_chrome.movMacOS: Desktop |
|
I would like confirmation of @Expensify/design Thank you. |
|
Styles are looking good to me. Let's double-check this is working the way @trjExpensify & @Expensify/product-pr expect! |
trjExpensify
left a comment
There was a problem hiding this comment.
All good from product. 👍
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.48-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.48-1 🚀
|
Explanation of Change
Fixed Issues
$ #72068
PROPOSAL: #72068 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisites:
Workspace with the Tags enabled
staging.new.expensify.com/workspaces/{{WORKSPACE_ID}}/tag-list/0PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop