Repository navigation
Remove Onyx.connect() for the key: ONYXKEYS.SUBSCRIPTION_RETRY_BILLING_STATUS_FAILED in src/libs/SubscriptionUtils.ts - #74533
Conversation
…G_STATUS_FAILED in src/libs/SubscriptionUtils.ts
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@joekaufmanexpensify you can ignore the Ping, we refactored the code here, no functional changes in this one |
Code Review Complete ✓I've performed a comprehensive review of this PR and found no code quality issues or violations. SummaryThis PR successfully refactors the subscription billing error handling by:
Files Reviewed
The refactoring follows React best practices by moving from global state subscriptions to component-level hooks, improving code maintainability and reducing potential side effects. |
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
No product considerations |
Reviewer Checklist
Screenshots/Videos
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.48-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.48-1 🚀
|

…G_STATUS_FAILED in src/libs/SubscriptionUtils.ts
Explanation of Change
Fixed Issues
$ #66452
PROPOSAL:
Tests
Offline tests
QA Steps
Verify that the following text is shown
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.