Repository navigation
Remove GBR on rejecting expense - #74543
Conversation
|
@truph01 will review this PR. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@truph01 I've marked this ready for review but skipped iOS screenshot as I have some issues with my Xcode. |
|
@heyjennahay @trjExpensify @garrettmknight Can one of you review too? |
|
🚧 @garrettmknight has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Tested on an adhoc build. A few things:
Screen.Recording.2025-11-10.at.6.29.23.PM.mov |
Remind me, does reject always come with a user comment? If so, then that makes sense for the submitter. |
Thanks @garrettmknight for checking. It's weird I tested this and I don't refresh it if you check my video. Let me get back to you. Quick question, I can't make out from your video if you're offline or online? |
It always comes with a comment, but it goes unread for the approver, too. |
Online. |
I'm not sure if this is needed right? What does the approver need to do with it after they reject it? |
Okay I'll check this further but if it's online then the fix might be needed from backend @lakchote |
I agree. I don't think the thread should be unread for the person taking the action. 🤔 |
|
I'd agree we could remove the unread. |
|
Doesn't the message come "from" the approver doing the rejecting? So I'm a bit confused why it's not "out of the box" not marking the chat as unread for them. :thinking_face: If we need to make a certain report action only actionable for the submitter, we should use the |
|
@truph01 Are you able to reproduce this issue? @garrettmknight can you please share the steps may be I am missing something here. |
|
Steps to reproduce:
Expected Result:
Actual Result
I investigated this and here's what I found. When we come back online and the web-twice-gbr-api-calls.mov |
@mananjadhav could you please post a video test for this one? it seems like there is one step missing there. |
|
@mananjadhav Lucien's auth PR is on prod. |
|
Thanks for the update. I'll resolve conflicts and test it once again. |
@mananjadhav any update? |
|
@trjExpensify @lakchote Just tested the fix. It's working fine now. @truph01 Please provide your final review and checklist so that we can merge soon. web-twice-reject-gbr.mov |
|
Checking the TS error now. |
|
cc @truph01 can you please review it? |
|
@truph01 quick bump |
|
Reviewing |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.67-0 🚀
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀
|
| if (!transactionID) { | ||
| return false; | ||
| } | ||
| const transactionViolations = getTransactionViolationsOfTransaction(transactionID); |
There was a problem hiding this comment.
@mananjadhav @truph01 Please don't use util functions to get Onyx data like this. As you know the Onyx.connect will be deprecated and we must pass Onyx data from UI to use.
Explanation of Change
Fixed Issues
$ #70565
PROPOSAL:
Tests
Precondition:
Tests
Offline tests
Same as Test steps
QA Steps
Same as Test steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-reject-gbr.mov
Android: mWeb Chrome
mweb-chrome-reject-gbr.mov
iOS: Native
iOS: mWeb Safari
mweb-safari-reject-gbpr.mov
MacOS: Chrome / Safari
web-reject-gbr.mov
MacOS: Desktop
desktop-reject-gbr.mov