Repository navigation
Avatar doesn't load when login from public room as existing user #74819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,7 +118,7 @@ describe('Deep linking', () => { | |
|
|
||
| await waitForBatchedUpdates(); | ||
|
|
||
| expect(lastVisitedPath).toBe(`/${ROUTES.REPORT}/${report.reportID}`); | ||
| expect(lastVisitedPath).toBe(`/${ROUTES.HOME}`); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to update to HOME since
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. False, this led to failing tests on main, see https://expensify.slack.com/archives/C01GTK53T8Q/p1765191955953569
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It introduced flakiness, decided to revert see https://expensify.slack.com/archives/C01GTK53T8Q/p1765217642441119?thread_ts=1765217169.365099&cid=C01GTK53T8Q |
||
|
|
||
| expect(hasAuthToken()).toBe(true); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ PERF-6 (docs)
Passing entire objects or functions as dependencies causes hooks to re-execute whenever any property changes, even unrelated ones. Specifying individual properties creates more granular dependency tracking, reducing unnecessary hook executions and improving performance predictability.
Since
userAccountSelectordepends onsession?.emailanduserAccountID(line 27), the dependency array should specify these individual properties instead:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorretheboy Can you fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham1206agra I think we can keep it as we add selector as dependency as a common pattern in our codebase. Do u think so?
App/src/hooks/useTripTransactions.ts
Line 49 in a7fab59