Skip to content

[CP Staging] Revert "fix: use correct receipt files with URIs when multi-scan via QAB" - #75039

Merged
mountiny merged 1 commit into
mainfrom
revert-74402-gijoe/73357
Nov 13, 2025
Merged

mountiny merged 1 commit into
mainfrom
revert-74402-gijoe/73357

Conversation

@cristipaval

@cristipaval cristipaval commented Nov 13, 2025 •

Copy link
Copy Markdown
Contributor

Reverts #74402

Reverting the PR because it not only breaks functionality, but also messes up the App cache, and the functionality is broken even with the production code afterwards, unless the user signs out or explicitly clears cache. See this Slack thread for more context.

$ #75013

NOTE for QA: Before you retest the fixed issue, please logout and login again, or Clear the cache and restart

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #75039.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Nov 13, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ages/iou/request/step/IOURequestStepScan/index.tsx 0.00% <ø> (ø)
...u/request/step/IOURequestStepScan/index.native.tsx 1.06% <0.00%> (+<0.01%) ⬆️
.../step/IOURequestStepScan/ReceiptPreviews/index.tsx 0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

@cristipaval cristipaval reopened this Nov 13, 2025
@cristipaval
cristipaval marked this pull request as ready for review November 13, 2025 12:26
@cristipaval
cristipaval requested review from a team as code owners November 13, 2025 12:26
@melvin-bot
melvin-bot Bot requested review from carlosmiceli and trjExpensify and removed request for a team November 13, 2025 12:26
@melvin-bot

melvin-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "fix: use correct receipt files with URIs when multi-scan via QAB" [CP Staging] Revert "fix: use correct receipt files with URIs when multi-scan via QAB" Nov 13, 2025

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny
mountiny merged commit bf3b16e into main Nov 13, 2025
4 checks passed
@mountiny
mountiny deleted the revert-74402-gijoe/73357 branch November 13, 2025 12:29
@melvin-bot melvin-bot Bot added the Emergency label Nov 13, 2025
@melvin-bot

melvin-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval

Copy link
Copy Markdown
Contributor Author

straight revert

OSBotify pushed a commit that referenced this pull request Nov 13, 2025
[CP Staging] Revert "fix: use correct receipt files with URIs when multi-scan via QAB"

(cherry picked from commit bf3b16e)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 13, 2025
@OSBotify OSBotify mentioned this pull request Nov 13, 2025
67 tasks done
@situchan

Copy link
Copy Markdown
Contributor

Confirmed fix: (you should Clear cache and restart or logout & relogin)

Screen.Recording.2025-11-13.at.6.33.00.PM.mov

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.57-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.58-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.58-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants