Repository navigation
fix:73574: Allow to dislay selected report on edit report page even if workspace doesn't have perDiem - #75147
Conversation
…f workspace doesnt have perDiem
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-11-14.at.19.54.13.moviOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-11-14.at.19.55.03.movMacOS: Chrome / SafariScreen.Recording.2025-11-14.at.19.40.40.movMacOS: Desktop |
| .filter((report): report is NonNullable<typeof report> => report !== undefined) | ||
| .filter((report) => { | ||
| if (isPerDiemRequest && report?.policyID) { | ||
| if (isPerDiemRequest && report?.policyID && selectedReport?.reportID !== report?.reportID) { |
There was a problem hiding this comment.
| if (isPerDiemRequest && report?.policyID && selectedReport?.reportID !== report?.reportID) { | |
| if (isPerDiemRequest && report?.policyID && selectedReportID !== report?.reportID) { |
I think we can use the existing selectedReportID
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Changed files failed(not realted to my PR), so merged main! |
|
Seems like this is not related to my PR, should i fix that? cc: @Pujan92 |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from a product perspective 👍
I think this PR states that it will be handled in the next PR. So I think we are good here. |
|
@amyevans looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not an emergency, failing test was unrelated to this PR |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.2.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀
|
Explanation of Change
This PR fixes a bug that caused the current report containing the expense not to be displayed when attempting to change the report when transferring an expense from one workspace (with PerDiem) to another (without PerDiem).
Fixed Issues
$#73574
PROPOSAL:#73574 (comment)
Tests
Precondition:
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
73574-android-native.mp4
Android: mWeb Chrome
73574-android-web.mp4
iOS: Native
73574-ios-native.mp4
iOS: mWeb Safari
73574-ios-web.mp4
MacOS: Chrome / Safari
73574-web.mp4
MacOS: Desktop
73574-desktop.mp4