Repository navigation
Fix/73744 - Custom avatar & default generated avatar modal is not closed when swiping down on the avatar - #75241
Conversation
…when swiping down on the avatar.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-17.at.8.24.13.PM.movAndroid: mWeb ChromeScreen.Recording.2025-11-17.at.8.25.20.PM.moviOS: HybridAppScreen.Recording.2025-11-17.at.8.23.33.PM.moviOS: mWeb SafariScreen.Recording.2025-11-17.at.8.24.37.PM.movMacOS: Chrome / SafariNA MacOS: DesktopNA |
| // Product Illustrations | ||
| import TeleScope from '@assets/images/product-illustrations/telescope.svg'; | ||
| import ToddBehindCloud from '@assets/images/product-illustrations/todd-behind-cloud.svg'; | ||
| // Simple Illustrations - Core ones that are actually used |
There was a problem hiding this comment.
| // Simple Illustrations - Core ones that are actually used | |
| // Simple Illustrations - Core ones that are actually used |
| @@ -51,6 +52,7 @@ const Illustrations = { | |||
| // Product Illustrations | |||
| TeleScope, | |||
| Telescope: TeleScope, // Alias for consistency | |||
There was a problem hiding this comment.
Consistency with what?
| Telescope: TeleScope, // Alias for consistency | |
| // Alias for consistency | |
| Telescope: TeleScope, |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.60-0 🚀
|
|
@dmkt9 there are no QA steps. Can you add them? |
Yes. The QA steps were already included in the OP.
|
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/cead22 in version: 9.2.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀
|
Explanation of Change
Add swipe-down-to-close functionality for the report avatar, workspace avatar, and profile avatar modals on mobile.
Fixed Issues
$ #73744
PROPOSAL: #73744 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Pre-condition: Have a workspace avatar & user default avatar
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
The issue doesn't occur
MacOS: Desktop
The issue doesn't occur