Repository navigation
Consolidate policy change logs - #76195
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Change makes sense to me 👍
yuwenmemon
left a comment
There was a problem hiding this comment.
@aldo-expensify all yours
aldo-expensify
left a comment
There was a problem hiding this comment.
Thanks @KioCoan !
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@KioCoan @joekaufmanexpensify @yuwenmemon Could you please clarify the expected result, we have no video in this PR. Do we expect 1 message with many replies (1 reply per change) or there must be 1 reply only with all changes? Now there is a separate reply per change Screen.Recording.2025-12-09.at.12.23.56.mp4 |
|
@jponikarchuk Thanks for testing, it is fine that for now the messages are separate, we need to merge and deploy the backend changes to be able to see the consolidated messages, so that result is fine for now. |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.2.74-0 🚀
|
|
@aldo-expensify Thanks a lot |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
Explanation of Change
Added the validation to display the
message.fieldswhen multiple policy changes happen in a consolidate message.Added support to fallback to old format with needed.
Added unit test to validate changes.
$ https://github.com/Expensify/Expensify/issues/566808
Tests
Offline tests
QA Steps
As an admin create a control workspace in OldDot
Invite an employee to the policy
Update the employee changing the Custom Field 1, Custom Field 2 and the Role in a single edit
Go to the #admins room in NewDot and verify that there is a single policy change logs showing the update of the 3 properties: Custom Field 1, Custom Field 2 and the Role
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.