Repository navigation
Conversation
melvin-bot
Bot
requested review from
AndrewGable
and removed request for
a team
December 1, 2025 08:16
|
@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
54 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. |
fabioh8010
approved these changes
Dec 1, 2025
This was referenced Dec 1, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
lakchote
self-requested a review
December 1, 2025 10:12
Contributor
|
Merging to fix tests failing notifications on Slack. See https://expensify.slack.com/archives/C01GTK53T8Q/p1764583036269189?thread_ts=1764582529.202019&cid=C01GTK53T8Q |
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.67-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.70-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
there is a failing test (ValidationUtils › isValidExpirationDate › Should return true for a valid formats expiration date in the future) because, the test check validation of the 12/2025 date and this date came today. The solution is to add a mock for the date to this file to do not change it every year
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari