Repository navigation
Fix pending notifications not being received after going online #76932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tylerkaraszewski
merged 9 commits into
Expensify:main
from
marufsharifi:fix/notifications-not-delivered-after-online
Dec 12, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
edabeb5
fix: ensure pending notifications are delivered when user comes back …
marufsharifi d22df5d
Merge branch 'main' into fix/notifications-not-delivered-after-online
marufsharifi ffbd887
keep the fix only for desktop web
marufsharifi c9cb0db
fixed failure test case
marufsharifi e02550b
Merge branch 'main' into fix/notifications-not-delivered-after-online
marufsharifi e0ea0ba
moved the triggerNotifications to report.ts to resolve the cycle depe…
marufsharifi edd05c7
fixed failure test
marufsharifi dafa9ed
fixed eslint issue
marufsharifi 6c63985
Merge branch 'main' into fix/notifications-not-delivered-after-online
marufsharifi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import type {OnyxCollection} from 'react-native-onyx'; | ||
| import {showReportActionNotification} from '@libs/actions/Report'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {ReportAction} from '@src/types/onyx'; | ||
| import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; | ||
|
|
||
| export default function triggerNotifications(onyxUpdates: OnyxServerUpdate[]): void { | ||
| for (const update of onyxUpdates) { | ||
| if (!update.shouldNotify && !update.shouldShowPushNotification) { | ||
| continue; | ||
| } | ||
|
|
||
| const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); | ||
| const reportActions = Object.values((update.value as OnyxCollection<ReportAction>) ?? {}); | ||
|
|
||
| for (const action of reportActions) { | ||
| if (action) { | ||
| showReportActionNotification(reportID, action); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.