Repository navigation
Fix report default report title field is grayed out even when online on a new workspace - #76962
Conversation
…on a new workspace
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
| <OfflineWithFeedback | ||
| pendingAction={reportTitlePendingFields.defaultValue} | ||
| shouldForceOpacity={!!reportTitlePendingFields.defaultValue} | ||
| shouldForceOpacity={reportTitlePendingFields.defaultValue === 'update'} |
There was a problem hiding this comment.
| shouldForceOpacity={reportTitlePendingFields.defaultValue === 'update'} | |
| shouldForceOpacity={reportTitlePendingFields.defaultValue === CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE} |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-12.at.09.18.59.movAndroid: mWeb ChromeScreen.Recording.2025-12-12.at.09.19.51.moviOS: HybridAppScreen.Recording.2025-12-12.at.09.13.32.moviOS: mWeb SafariScreen.Recording.2025-12-12.at.09.15.41.movMacOS: Chrome / SafariScreen.Recording.2025-12-12.at.09.10.26.mov |
deetergp
left a comment
There was a problem hiding this comment.
LGTM 👍
@heyjennahay Does everything here seem okay from a product perspective?
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.79-0 🚀
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Explanation of Change
This PR only force apply the opacity when the pending field is update.
Fixed Issues
$ #75787
PROPOSAL: #75787 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4