Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions src/pages/ReportDetailsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import Permissions from '@libs/Permissions';
import {isPolicyAdmin as isPolicyAdminUtil, isPolicyEmployee as isPolicyEmployeeUtil, shouldShowPolicy} from '@libs/PolicyUtils';
import {getOneTransactionThreadReportID, getOriginalMessage, getTrackExpenseActionableWhisper, isDeletedAction, isMoneyRequestAction, isTrackExpenseAction} from '@libs/ReportActionsUtils';
import {getReportName as getReportNameFromReportNameUtils} from '@libs/ReportNameUtils';
import {
canAddOrDeleteTransactions,
canDeleteCardTransactionByLiabilityType,
Expand All @@ -65,7 +66,6 @@
getParticipantsList,
getReportDescription,
getReportFieldKey,
getReportName,
isAdminOwnerApproverOrReportOwner,
isArchivedNonExpenseReport,
isCanceledTaskReport as isCanceledTaskReportUtil,
Expand Down Expand Up @@ -155,6 +155,7 @@
const {isOffline} = useNetwork();
const {isRestrictedToPreferredPolicy, preferredPolicyID} = usePreferredPolicy();
const styles = useThemeStyles();
const expensifyIcons = useMemoizedLazyExpensifyIcons(['Users', 'Gear', 'Send', 'Folder', 'UserPlus', 'Pencil', 'Checkmark', 'Building', 'Exit', 'Bug', 'Camera', 'Trashcan'] as const);
const backTo = route.params.backTo;

const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`, {canBeMissing: true});
Expand All @@ -173,7 +174,6 @@
const transactionThreadReportID = useMemo(() => getOneTransactionThreadReportID(report, chatReport, reportActions ?? [], isOffline), [reportActions, isOffline, report, chatReport]);
// eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
const {isSmallScreenWidth} = useResponsiveLayout();
const expensifyIcons = useMemoizedLazyExpensifyIcons(['Users', 'Gear', 'Send', 'Folder', 'UserPlus', 'Pencil', 'Checkmark', 'Building', 'Exit', 'Bug', 'Camera', 'Trashcan'] as const);

/* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
const [transactionThreadReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`, {canBeMissing: true});
Expand Down Expand Up @@ -324,15 +324,6 @@
}, [report?.reportID, isOffline, isPrivateNotesFetchTriggered, isSelfDM]);

const leaveChat = useCallback(() => {
if (isChatThread && report.parentReportID) {
Navigation.dismissModalWithReport({reportID: report.parentReportID});
Navigation.isNavigationReady().then(() => {
const isWorkspaceMemberLeavingWorkspaceRoom = isWorkspaceMemberLeavingWorkspaceRoomUtil(report, isPolicyEmployee, isPolicyAdmin);
leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom);
});
return;
}

Navigation.dismissModal();
Navigation.isNavigationReady().then(() => {
if (isRootGroupChat) {
Expand All @@ -342,13 +333,12 @@
const isWorkspaceMemberLeavingWorkspaceRoom = isWorkspaceMemberLeavingWorkspaceRoomUtil(report, isPolicyEmployee, isPolicyAdmin);
leaveRoom(report.reportID, isWorkspaceMemberLeavingWorkspaceRoom);
});
}, [isRootGroupChat, isPolicyEmployee, isChatThread, isPolicyAdmin, quickAction?.chatReportID, report]);
}, [isRootGroupChat, isPolicyEmployee, isPolicyAdmin, quickAction?.chatReportID, report]);

const shouldShowLeaveButton = canLeaveChat(report, policy, !!reportNameValuePairs?.private_isArchived);
const shouldShowGoToWorkspace = shouldShowPolicy(policy, false, currentUserPersonalDetails?.email) && !policy?.isJoinRequestPending;

// eslint-disable-next-line @typescript-eslint/no-deprecated
const reportName = Parser.htmlToText(getReportName(report, undefined, undefined, undefined, undefined, reportAttributes));
const reportName = Parser.htmlToText(getReportNameFromReportNameUtils(report, reportAttributes));
const additionalRoomDetails =
(isPolicyExpenseChat && !!report?.isOwnPolicyExpenseChat) || isExpenseReportUtil(report) || isPolicyExpenseChat || isInvoiceRoom
? chatRoomSubtitle
Expand Down Expand Up @@ -556,11 +546,10 @@
}

return items;
}, [

Check warning on line 549 in src/pages/ReportDetailsPage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

React Hook useMemo has missing dependencies: 'expensifyIcons.Bug', 'expensifyIcons.Building', 'expensifyIcons.Checkmark', 'expensifyIcons.Exit', 'expensifyIcons.Folder', 'expensifyIcons.Gear', 'expensifyIcons.Pencil', 'expensifyIcons.Send', 'expensifyIcons.UserPlus', and 'expensifyIcons.Users'. Either include them or remove the dependency array
isSelfDM,
isArchivedRoom,
isGroupChat,
expensifyIcons,
isDefaultRoom,
isChatThread,
isPolicyEmployee,
Expand Down Expand Up @@ -662,11 +651,10 @@
style={[styles.w100, styles.mb3]}
/>
);
}, [

Check warning on line 654 in src/pages/ReportDetailsPage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

React Hook useMemo has a missing dependency: 'expensifyIcons.Camera'. Either include it or remove the dependency array
isChatRoom,
isThread,
isGroupChat,
expensifyIcons,
icons,
report,
styles.avatarXLarge,
Expand Down Expand Up @@ -756,7 +744,7 @@
const nameSectionGroupWorkspace = (
<OfflineWithFeedback
pendingAction={report?.pendingFields?.reportName}
errors={report?.errorFields?.reportName}
errors={report?.errorFields?.reportName ?? null}
errorRowStyles={[styles.ph5]}
onClose={() => clearPolicyRoomNameErrors(report?.reportID)}
>
Expand Down Expand Up @@ -803,7 +791,7 @@
const nameSectionTitleField = !!titleField && (
<OfflineWithFeedback
pendingAction={report.pendingFields?.reportName}
errors={report.errorFields?.reportName}
errors={report.errorFields?.reportName ?? null}
errorRowStyles={styles.ph5}
key={`menuItem-${fieldKey}`}
onClose={() => clearPolicyRoomNameErrors(report.reportID)}
Expand Down
Loading