Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@FitseTLT will review this PR |
| @@ -147,7 +148,9 @@ function ReportActionItemParentAction({ | |||
| <AnimatedEmptyStateBackground /> | |||
| <OfflineWithFeedback | |||
| shouldDisableOpacity | |||
There was a problem hiding this comment.
❌ PERF-4 (docs)
The call to getMicroSecondOnyxErrorWithTranslationKey() creates a new object on every render when report?.errorFields?.createChat is truthy. This new object reference causes unnecessary re-renders of the OfflineWithFeedback component.
Suggested fix: Memoize the error object using useMemo:
const errors = useMemo(() => {
if (report?.errorFields?.createChatThread) {
return report.errorFields.createChatThread;
}
if (report?.errorFields?.createChat) {
return getMicroSecondOnyxErrorWithTranslationKey('report.genericCreateReportFailureMessage');
}
return null;
}, [report?.errorFields?.createChatThread, report?.errorFields?.createChat]);
// Then use it:
<OfflineWithFeedback
shouldDisableOpacity
errors={errors}
errorRowStyles={[styles.ml10, styles.mr2]}
onClose={() => navigateToConciergeChatAndDeleteReport(report?.reportID, undefined, true)}
>|
@FitseTLT can you review? |
Yep 👍 |
|
Some comments on your test steps @truph01
And also, your onyx state sets |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-02.20-28-23.mp4Android: mWeb Chrome2026-01-03.00-45-26.mp4iOS: HybridApp2026-01-02.21-43-33.mp4iOS: mWeb Safari2026-01-03.00-46-26.mp4MacOS: Chrome / Safari2026-01-03.00-44-47.mp4 |
|
@truph01 Can u also pls add the issue link on |
|
@FitseTLT I addressed your comments. Thanks for your suggestion. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.2.93-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.93-1 🚀
|
…-button-when-report-has-create-error fix: missing error message and x button in failure chat thread
Explanation of Change
Problem
How this PR can fix the issue
Onyx state.txt
Fixed Issues
$ #78112
PROPOSAL:
Tests
onyx-state.txt
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-19.at.13.10.27.mov
Android: mWeb Chrome
Screen.Recording.2025-12-19.at.13.11.03.mov
iOS: Native
Screen.Recording.2025-12-19.at.13.06.58.mov
iOS: mWeb Safari
Screen.Recording.2025-12-19.at.13.07.43.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-19.at.13.01.34.mov