Repository navigation
[NO QA] Making tags modal clearer - #78609
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 02f0d2db..f66f5ca8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5271,7 +5271,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
title: 'Sie haben noch keine Tags erstellt',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Füge ein Tag hinzu, um Projekte, Standorte, Abteilungen und mehr zu verfolgen.',
- subtitleHTML: `<muted-text><centered-text>Importieren Sie eine Tabelle, um Tags für die Nachverfolgung von Projekten, Standorten, Abteilungen und mehr hinzuzufügen. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Erfahren Sie mehr</a> über die Formatierung von Tag-Dateien.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Fügen Sie Tags hinzu, um Projekte, Standorte, Abteilungen und mehr zu verfolgen. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Erfahren Sie mehr</a> über das Formatieren von Tag-Dateien für den Import.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>Ihre Tags werden derzeit über eine Buchhaltungsverbindung importiert. Gehen Sie zu <a href="${accountingPageURL}">Buchhaltung</a>, um Änderungen vorzunehmen.</centered-text></muted-text>`,
},
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 6e0f0cba..643df9a2 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5277,7 +5277,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
title: "Vous n'avez créé aucune étiquette",
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Ajoutez une étiquette pour suivre les projets, les lieux, les services et plus encore.',
- subtitleHTML: `<muted-text><centered-text>Importez une feuille de calcul pour ajouter des tags afin de suivre les projets, les sites, les services, et plus encore. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">En savoir plus</a> sur le formatage des fichiers de tags.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Ajoutez des tags pour suivre les projets, les sites, les services, et plus encore. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">En savoir plus</a> sur le formatage des fichiers de tags pour l’importation.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>Vos tags sont actuellement importés depuis une connexion comptable. Rendez-vous dans la section <a href="${accountingPageURL}">Comptabilité</a> pour effectuer des modifications.</centered-text></muted-text>`,
},
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 509be999..b396cf0d 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5254,7 +5254,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
title: 'Non hai creato alcun tag',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Aggiungi un tag per tenere traccia di progetti, sedi, reparti e altro.',
- subtitleHTML: `<muted-text><centered-text>Importa un foglio di calcolo per aggiungere tag per tenere traccia di progetti, sedi, reparti e altro ancora. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Scopri di più</a> sulla formattazione dei file dei tag.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Aggiungi tag per tenere traccia di progetti, sedi, reparti e altro ancora. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Scopri di più</a> sulla formattazione dei file di tag per l’importazione.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>I tuoi tag vengono attualmente importati da una connessione contabile. Vai su <a href="${accountingPageURL}">contabilità</a> per apportare eventuali modifiche.</centered-text></muted-text>`,
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8609b55c..a296e75f 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -5221,7 +5221,7 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
title: 'まだタグを作成していません',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'タグを追加して、プロジェクト、勤務地、部門などを追跡しましょう。',
- subtitleHTML: `<muted-text><centered-text>スプレッドシートをインポートして、プロジェクト、所在地、部署などを追跡するためのタグを追加します。タグファイルの書式設定については、<a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">詳細はこちら</a>をご覧ください。</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>タグを追加して、プロジェクト、所在地、部署などを追跡しましょう。インポート用のタグファイルの書式設定については、<a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">詳しくはこちら</a>をご覧ください。</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>現在、タグは会計連携からインポートされています。変更を行うには、<a href="${accountingPageURL}">会計</a>に移動してください。</centered-text></muted-text>`,
},
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 41f61ce2..59674506 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5246,7 +5246,9 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
title: 'Je hebt nog geen tags aangemaakt',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Voeg een tag toe om projecten, locaties, afdelingen en meer bij te houden.',
- subtitleHTML: `<muted-text><centered-text>Importeer een spreadsheet om tags toe te voegen voor het bijhouden van projecten, locaties, afdelingen en meer. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Meer informatie</a> over het formatteren van tagbestanden.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Voeg tags toe om projecten, locaties, afdelingen en meer bij te houden. <a href="${
+ CONST.IMPORT_TAGS_EXPENSIFY_URL //_/\__/_/ \_,_/\__/\__/\_,_/
+ }">Meer informatie</a> over het opmaken van tagbestanden voor import.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>Je tags worden momenteel geïmporteerd vanuit een boekhoudkoppeling. Ga naar <a href="${accountingPageURL}">Boekhouding</a> om wijzigingen aan te brengen.</centered-text></muted-text>`,
},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index c34bac42..e583736e 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5237,7 +5237,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
title: 'Nie utworzyłeś jeszcze żadnych tagów',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Dodaj znacznik, aby śledzić projekty, lokalizacje, działy i nie tylko.',
- subtitleHTML: `<muted-text><centered-text>Zaimportuj arkusz kalkulacyjny, aby dodać tagi do śledzenia projektów, lokalizacji, działów i nie tylko. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Dowiedz się więcej</a> o formatowaniu plików tagów.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Dodaj tagi, aby śledzić projekty, lokalizacje, działy i nie tylko. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Dowiedz się więcej</a> o formatowaniu plików tagów do importu.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>Twoje tagi są obecnie importowane z połączenia księgowego. Przejdź do <a href="${accountingPageURL}">księgowości</a>, aby wprowadzić zmiany.</centered-text></muted-text>`,
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 1981d0e2..36d20aa1 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5237,7 +5237,7 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
title: 'Você não criou nenhuma tag',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Adicione uma tag para acompanhar projetos, locais, departamentos e muito mais.',
- subtitleHTML: `<muted-text><centered-text>Importe uma planilha para adicionar tags para rastrear projetos, locais, departamentos e muito mais. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Saiba mais</a> sobre a formatação de arquivos de tags.</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>Adicione tags para rastrear projetos, locais, departamentos e muito mais. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Saiba mais</a> sobre como formatar arquivos de tag para importação.</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>Suas tags estão sendo importadas de uma conexão contábil. Vá até <a href="${accountingPageURL}">contabilidade</a> para fazer qualquer alteração.</centered-text></muted-text>`,
},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 15695905..7d1f55de 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5143,7 +5143,7 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
title: '你尚未创建任何标签',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: '添加标签以跟踪项目、地点、部门等。',
- subtitleHTML: `<muted-text><centered-text>导入电子表格以添加标签,用于跟踪项目、地点、部门等。<a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">了解详情</a>,以获取有关标记文件格式的更多信息。</centered-text></muted-text>`,
+ subtitleHTML: `<muted-text><centered-text>添加标签以跟踪项目、地点、部门等。<a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">了解详情</a>,以便将标签文件格式化为可导入。</centered-text></muted-text>`,
subtitleWithAccounting: ({accountingPageURL}: EmptyTagsSubtitleWithAccountingParams) =>
`<muted-text><centered-text>您的标签当前正从会计连接中导入。请前往<a href="${accountingPageURL}">会计</a>页面进行任何更改。</centered-text></muted-text>`,
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@jamesdeanexpensify, we also need to update the other languages. |
|
Are you able to help with that piece? I think there's an easier way for engineers to do it that I haven't learned yet. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.93-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.93-1 🚀
|
…patch-7 [NO QA] Making tags modal clearer
Explanation of Change
Making this copy a bit clearer:
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Rolefield and verify that the copy is updated.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari