Skip to content

[CP Staging] Revert "fix merchant field not working" - #78635

Closed
mountiny wants to merge 1 commit into
mainfrom
revert-77658-fixnavigation
Closed

mountiny wants to merge 1 commit into
mainfrom
revert-77658-fixnavigation

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #77658

Fixes #78590

@mountiny
mountiny requested review from a team as code owners December 31, 2025 13:27
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify, flaviadefaria, heyjennahay, joekaufmanexpensify and trjExpensify and removed request for a team December 31, 2025 13:27
@melvin-bot
melvin-bot Bot requested review from mollfpr and removed request for a team December 31, 2025 13:27
@melvin-bot

melvin-bot Bot commented Dec 31, 2025

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Dec 31, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ges/iou/request/step/IOURequestStepDescription.tsx 0.00% <0.00%> (ø)
.../pages/iou/request/step/IOURequestStepMerchant.tsx 0.00% <0.00%> (ø)
...t/step/DiscardChangesConfirmation/index.native.tsx 0.00% <0.00%> (ø)
... and 12 files with indirect coverage changes

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78635.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8abc6aa6092928bf4b469d21acb3b474a9499a1b/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@mountiny

Copy link
Copy Markdown
Contributor Author

Closing as the state after the revert is actually worse than with the partial fix

@mountiny mountiny closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Due for payment 2026-03-23] [$250] iOS - Expense - Discard changes modal is hidden behind keyboard

1 participant