Repository navigation
fix: Arrow key navigation not working in Columns selection #78869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JS00001
merged 86 commits into
Expensify:main
from
TaduJR:fix-Arrow-key-navigation-not-working-in-Columns-selection
Mar 17, 2026
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
ed8a0ff
fix: Arrow key navigation not working in Columns selection
TaduJR 9932670
chore: formatting using prettier
TaduJR 0136871
fix: lint errors in DraggableList keyboard navigation
TaduJR 1614dbd
fix: resolve tabIndex override and remove conflicting role in Sortabl…
TaduJR 45c804c
fix: add eslint-disable for tabIndex in SortableItem
TaduJR 5c2f16e
fix: use explicit role instead of eslint-disable in SortableItem
TaduJR cf27c80
Merge branch 'Expensify:main' into fix-Arrow-key-navigation-not-worki…
TaduJR 20b12b5
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 60da1ac
Merge branch 'fix-Arrow-key-navigation-not-working-in-Columns-selecti…
TaduJR 84e8667
refactor: remove useMemo, and use flatMap
TaduJR 632ced7
fix: revert isDisabled variable name to original
TaduJR 1392f4a
Merge branch 'Expensify:main' into fix-Arrow-key-navigation-not-worki…
TaduJR 1b19484
Merge branch 'Expensify:main' into fix-Arrow-key-navigation-not-worki…
TaduJR 76828a5
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 618254d
feat: add Enter key support to select focused item in DraggableList
TaduJR 18f1a5d
Merge branch 'fix-Arrow-key-navigation-not-working-in-Columns-selecti…
TaduJR bcb150e
revert: Unwanted Changes
TaduJR 251a751
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 8fbc853
fix: prevent keyboard navigation conflicts between multiple Draggable…
TaduJR b0f092b
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR e020848
Merge branch 'fix-Arrow-key-navigation-not-working-in-Columns-selecti…
TaduJR 85827a2
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 1c82cdf
fix: Tab navigation accessibility in DraggableList columns selection
TaduJR 0f4123a
fix: resolve TypeScript and ESLint errors in DraggableList accessibil…
TaduJR 7e99148
Merge branch 'Expensify:main' into fix-Arrow-key-navigation-not-worki…
TaduJR 52f75be
testing
TaduJR 5490f2a
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR f6a0236
refactor: use named functions for pointer enter handlers in SearchCol…
TaduJR 5144f2b
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 530ef97
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 5d5ade5
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR aade6c2
chore: remove redundant useCallback/useMemo and restore tabIndex comment
TaduJR 78dbb2b
chore: remove unnecessary comments
TaduJR b679f55
fix: add onFocus handlers for keyboard-only list switching and Save b…
TaduJR 081337b
fix: default isKeyboardActive to false to avoid regressions in other …
TaduJR 1b23ac9
fix: add eslint-disable for props spreading in SortableItem
TaduJR 70e36e5
feat: add seamless arrow key navigation across grouped lists per W3C APG
TaduJR 4a48d21
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 9b6557d
fix: preserve tabIndex=-1 default for non-keyboard lists and deactiva…
TaduJR 24d9539
fix: correct JSDoc for overflow callback props
TaduJR e102359
fix: add role=listbox/option only when keyboard-managed to fix ARIA v…
TaduJR a179a0f
refactor: use CONST.ROLE for ARIA roles and clean up conditional props
TaduJR 9552836
fix: add keyboard navigation to DraggableList using W3C grouped listb…
TaduJR 516fe1f
fix: reset focus on Tab-out and sync Tab position with arrow key navi…
TaduJR 1fb54e3
fix: guard focusout listener for web and sync Tab with arrow key focus
TaduJR b8927ce
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 07a642f
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 0e5af12
refactor: extract focusout logic into platform-specific useResetFocus…
TaduJR d9b12fe
fix: scroll focused item into view during arrow key navigation
TaduJR a2fe0e8
fix: reset focus after column toggle to prevent acting on wrong item
TaduJR 13b600c
refactor: pass isFocused through renderItem params and extract useMul…
TaduJR 141edd3
fix: match useResetFocusOnBlur native signature with web and add miss…
TaduJR 5f42d7d
fix: guard against negative pending focus index in useMultiListFocusM…
TaduJR 5b477e5
fix: handle Space key to prevent dnd-kit drag activation during colum…
TaduJR 7a61b5b
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR efbee38
fix: Simplify DraggableList keyboard nav to be self-contained
TaduJR ee1145b
fix: arrow key handlers to only activate when list has DOM focus
TaduJR dcd3491
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 20ccd42
fix: Preserve focusedIndex during transient focus loss from React re-…
TaduJR c0e778b
chore: Remove unnecessary useCallback and redundant ReactNode union type
TaduJR 450d32d
fix: narrow focusedKey type to satisfy TypeScript indexOf signature
TaduJR 934551e
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 2a459f8
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR e7d26f5
fix: Extract useListKeyboardNav hook and add cross-group keyboard nav…
TaduJR ea6df52
fix: arrow key hijacking on pages using DraggableList without selection
TaduJR 03a326a
fix: Prevent double-toggle by disabling Enter/Space shortcuts when Pr…
TaduJR 34186d4
fix: Restore comments from main branch in DraggableList and SortableItem
TaduJR 07e62e2
fix: Restore main-branch comments lost in conflict resolution, useCal…
TaduJR dc2658a
fix: Return explicit booleans from getDraggableItemFlags
TaduJR 4a0e911
fix: Combine reorder-tracking and bounds-clamping effects to avoid ex…
TaduJR 52a3715
test: Add unit tests for useListKeyboardNav hook
TaduJR d634952
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 0e1fd7d
fix: Align focus behavior with W3C APG: stay at same index on toggle,…
TaduJR 238bbf5
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 7642bbb
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR ecd14c8
chore: Add comment explaining tabIndex={-1} on MultiSelectListItem ch…
TaduJR 615b2b8
fix: sync focusedIndex on Tab entry to match arrow-key toggle behavior
TaduJR e15829d
test: add focusin sync test for Tab-focused items
TaduJR 0e3b08e
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 79430df
Merge remote-tracking branch 'upstream/main' into fix-Arrow-key-navig…
TaduJR 462b92e
Merge branch 'Expensify:main' into fix-Arrow-key-navigation-not-worki…
TaduJR 7414dae
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 1de1c39
Merge branch 'main' of https://github.com/TaduJR/App into fix-Arrow-k…
TaduJR 38da420
fix: replace getDraggableItemFlags with typed callback props
TaduJR db1bcf5
refactor: remove Enter/Space shortcuts from useListKeyboardNav — hand…
TaduJR 813dd06
chore: CI restart
TaduJR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.