Repository navigation
Bump heic-to to v1.11.14 - #79212
Bump heic-to to v1.11.14#79212
heic-to to v1.11.14#79212Conversation
|
|
|
@thienlnam can you please generate adhoc build here? (web only) |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@thienlnam can you run adhoc build? |
|
@gijoe0295 please merge main, add screenshots and mark ready for review |
|
The dev site is still crashing for me. I think we need adhoc build to verify it. @thienlnam Can you run adhoc build? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb Chrome77532-mchrome.moviOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari77532-web.mov |
situchan
left a comment
There was a problem hiding this comment.
@thienlnam please generate adhoc build
|
🚧 @thienlnam has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@gijoe0295 have you tested adhoc build above? That will expire soon (app update modal will show) so test asap |
|
@situchan Tested and worked well. Ready for your review. |
|
@thienlnam Can you review? |
|
The failed lint is not related to this PR |
|
Can't merge this with an ESLint failure. Can you try pulling main, or otherwise fix the linter errors? |
|
@yuwenmemon All good now. |
|
🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.17-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
Explanation of Change
There was a known memory issue in Safari that caused infinite loading or crash when converting
heicfiles inheic-tolibrary which was resolved in v1.11.14.Fixed Issues
$ #77532
PROPOSAL: #77532 (comment)
Tests
Precondition:
heicfile saved in your device, can get one by Sharing a Photo from Photos app > Export Unmodified Original > Saving to iCloud Drive or use https://drive.google.com/file/d/1pi5if4sy6Ax0p4AtmkPxo_RmtZUhkxOG/viewOffline tests
None
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-22.at.22.24.51.mov
Android: mWeb Chrome
Screenrecording_20260122_221831.mp4
iOS: Native
Screen.Recording.2026-01-24.at.16.01.06.mov
iOS: mWeb Safari
ScreenRecording_01-24-2026.15-30-34_1.1.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-01-22.at.21.58.32.mov