Repository navigation
Fix incorrect chat opening after merging expense with self DM - #79275
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp79275-android-hybrid-001.mp4Android: mWeb Chrome79275-mweb-chrome-001.mp4iOS: HybridApp79275-ios-hybrid-001.mp4iOS: mWeb Safari79275-mweb-safari-001.mp4MacOS: Chrome / Safari79275-web-chrome-001.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Thanks @marufsharifi for the PR.
@MonilBhavsar Changes LGTM and works well too.
Over to you. Thanks.
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.0-0 🚀
|
[CP Staging] Revert #79275 – "Fix incorrect chat opening after merging expense with self DM "
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀
|
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.1-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.1-1 🚀
|
|
@marufsharifi Please raise the PR again as this PR got reverted unfortunately. As mentioned here, it does not look like we caused the mentioned blocker. |
Explanation of Change
Ensure the destination report is opened instead of the workspace chat after merging an expense with a self DM expense.
Fixed Issues
$ #78842
PROPOSAL: #78842 (Comment)
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-10-20.at.11.19.27.AM.mov
Android: mWeb Chrome
Screen.Recording.1404-10-20.at.11.21.19.AM.mov
iOS: Native
Screen.Recording.1404-10-20.at.11.24.45.AM.mov
iOS: mWeb Safari
Screen.Recording.1404-10-20.at.11.27.44.AM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-10-20.at.11.08.30.AM.mov