Repository navigation
[Internal QA] Fix/79446 - "Add shipping details" disappears after entering private info in profile - #79988
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f038a0a214
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I got this error when adding shipping information Screen.Recording.2026-01-21.at.12.17.32.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-21.at.22.21.11.movAndroid: mWeb ChromeScreen.Recording.2026-01-21.at.22.13.20.moviOS: HybridAppScreen.Recording.2026-01-21.at.22.19.55.moviOS: mWeb SafariScreen.Recording.2026-01-21.at.22.11.24.movMacOS: Chrome / SafariScreen.Recording.2026-01-21.at.22.08.51.mov |
|
@dmkt9 Thank you, the PR looks good, but we should wait for BE fix cc @cristipaval |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@dmkt9 @cristipaval I confirmed we're still showing the option to order a card after entering personal info in the account, but actually ordering the card isn't working. This is with a real card/bank account, so there is no restriction on ordering for it. The magic code also doesn't initially show up. I have to wait 30 seconds and then request a new one before it appears. Here are results of failing API request: The user doesn't actually enter DOB though, you select it via date picker. 2026-03-04_12-18-21.mp4 |
|
Thanks for testing, @joekaufmanexpensify 🙇 @dmkt9, the logs show that the App sent '2026-03-04' (today) as the date of birth. Could you please check in the App code? |
@cristipaval Thanks. I've added the DOB validation. If it's invalid, the flow will start at the DOB step with the blank input. |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
Thanks for the quick fix! I've just triggered a new build for @joekaufmanexpensify when he starts working today 🙏 |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@dmkt9, the fix is not sufficient. You have to also check that it meets the minimum age requirement |
@cristipaval Ah, thanks. I've updated it to use |
Huh, interesting. Usually in our DOB forms, we default to the most recent date you can select while still meeting our requirements (which I believe is whatever day makes you exactly 18 years old). I assumed I just selected that, but maybe the DOB form on Profile defaults to today's date, instead? |
|
I will test in a bit 👍 |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Yeah I confirmed the DOB form on profile defaults to today's date. I will report that as a bug separately. 2026-03-26_10-56-29.mp4 |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Working well from my perspective
|
Thank you all for the effort on this one! |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
This needs to be internal QA, right? I will plan to do it today |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647021518 |
@joekaufmanexpensify Thank you very much. |
|
Tests well on staging! Checked off for QA |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|

Explanation of Change
This PR ensures that:
Fixed Issues
$ #79446
PROPOSAL: #79446 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
mac.safari.mp4