Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contributingGuides/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,16 @@ Additionally, if you want to discuss an idea with the open source community with
16. Please pay attention to the pull request template, especially to how we link PRs with issues they fix. Make sure you don't use GitHub keywords such as `fixes` in your PR description, as this can break our current automated steps for issue management. Follow the PR template format carefully.
17. Upon submission of a PR, please include a numbered list of explicit testing steps for each platform (Web, iOS, Android, and Mobile Web) to confirm the fix works as expected and there are no regressions.
18. Please add a screenshot of the app running on each platform (Web, iOS, Android, Mobile Web).
19. Please review the [PR Authoring & Reviewing Best Practices](./PR_AUTHOR_REVIEWER_BEST_PRACTICES.md) for standards on PR titles, testing responsibilities, and the review workflow.

### Completing the final checklist
19. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued.
20. The items requiring your completion consist of:
20. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued.
21. The items requiring your completion consist of:
1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md)).
2. Identifying and noting the offending PR that caused the bug (if any).
3. Commenting on the offending PR to note the bug it caused and why (if applicable).
4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again.
21. Once the above items have been successfully completed, then payments will begin to be issued.
22. Once the above items have been successfully completed, then payments will begin to be issued.

### Timeline expectations and asking for help along the way
- If you have made a change to your pull request and are ready for another review, leave a comment that says "Updated" on the pull request itself.
Expand Down
1 change: 1 addition & 0 deletions contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ C+ are contributors who are experienced at working with Expensify and have gaine
- Follow our Code of Conduct, Contributing.md and README.md docs and processes.
- Comment and fix bugs in a timely manner.
- Clear communicator.
- Familiar with [PR Authoring & Reviewing Best Practices](./PR_AUTHOR_REVIEWER_BEST_PRACTICES.md).
- Bonus points:
- Help other contributors by commenting on their issues.
- Actively involved in the #expensify-open-source slack channel.
Expand Down
Loading