Repository navigation
[Home Page] Prevent Pay action from showing after user leaves workspace #81303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grgia
merged 5 commits into
Expensify:main
from
software-mansion-labs:@adamgrzybowski/fix-isPayer-helper
Feb 6, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a6f7c6d
Prevent Pay action from showing after user leaves workspace
adamgrzybowski 45da66f
Fix isPayer blocking payers when policy.employeeList is not loaded
adamgrzybowski a100d77
Fix IOUTest to use admin session for canIOUBePaid checks
adamgrzybowski 2f57eb2
Merge branch 'main' into @adamgrzybowski/fix-isPayer-helper
adamgrzybowski c894383
Merge branch 'main' into @adamgrzybowski/fix-isPayer-helper
adamgrzybowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adamgrzybowski,
We’re seeing a case here where
employeeListis partially loaded and does not include the current user, which causesisPayerto return false.Do you think it makes sense to guard this by checking
!isEmptyObject(policy?.employeeList?.[currentUserEmailParam]),or should the backend guarantee that the current user is always included even when returning a partial list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the guard you mentioned solves our problem completely. This partial list behavior is a potential trap for other upcoming features so maybe let's fix the backend? But I don't have a strong opinion on this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, the BE fix looks more comprehensive—let’s get @grgia thought on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, though it should already do this.