Repository navigation
fix: Country selection page is skipped after adding non-US BA and refreshing browser - #81379
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
@joekaufmanexpensify can you sense check this? I'm not sure it's right that you'd lose your progress here?
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-03-25.10.36.24.movAndroid: mWeb Chrome2026-03-25.10.41.31.moviOS: HybridApp2026-03-25.10.36.24.moviOS: mWeb Safari2026-03-25.10.41.31.movMacOS: Chrome / Safari2026-03-25.10.21.37.mov |
@joekaufmanexpensify |
@joekaufmanexpensify |
|
@joekaufmanexpensify |
|
@trjExpensify |
|
I've reached out to @joekaufmanexpensify to put this on his radar, it was probably lost in the ether. |
|
Yes, definitely got filtered out in my email and I did not otherwise see it since I'm not assigned. Catching up now. |
It's not really losing your progress IMO. The user successfully adds the personal bank account the first go round. Once they finish adding a deposit account, we expect to show the country selector the next time they add a bank account. The only exception is if the user is a workspace admin. Then, they see the account type selector page where they choose between personal and business bank accounts, after tapping "add bank account" on Wallet. LMK if any other questions! |
|
Great stuff, thanks for confirming! |
|
Thanks! @paulnjs |
|
@ZhenjaHorbach Conflict is resolved |
|
I have a crash after adding a bank account 2026-03-18.10.37.07.mov |
|
@ZhenjaHorbach I updated but during the PR in review there is new screen added before Country selection page. With the initial solution, we will land on the first screen so will be "What do you want to do with your bank account?" before Country selection, we will keep this behavior or still need update to open Country selection page(skip new screen)
|
I suppose we don't need to skip this screen |
Thanks. I also updated the test steps to match with new screen |
|
Now we have a main issue again 2026-03-20.09.39.28.mov |
|
@ZhenjaHorbach Could you please help to check again? It still works fine on my side web-resize.mp4 |
|
Strange |
|
Okay |
|
LGTM! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help Site Review — No changes required I reviewed the code changes in this PR against all help site articles under PR changes summary:
Why no help site changes are needed:
The existing documentation already describes the correct behavior that this bug fix ensures works properly:
No help site PR is needed. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|


Explanation of Change
Fixed Issues
$#80323
PROPOSAL:#80323 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_w.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mp4