Repository navigation
[No QA] 81443: Reduce cont of Eslint issues from 399 to 378 #81588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
840fde7
a527d0a
cbbfe76
f613659
1fc69f1
9a2cbe8
2488f70
4766386
c6b095c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,8 @@ | |
|
|
||
| let currencyList: OnyxValues[typeof ONYXKEYS.CURRENCY_LIST] = {}; | ||
|
|
||
| /* eslint-disable rulesdir/prefer-onyx-connect-in-libs -- may refactor to useOnyx/connectWithoutView later */ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't work to ignore the warnings. |
||
| Onyx.connect({ | ||
|
Check warning on line 12 in src/libs/CurrencyUtils.ts
|
||
|
abbasifaizan70 marked this conversation as resolved.
Resolved
|
||
| key: ONYXKEYS.CURRENCY_LIST, | ||
| callback: (val) => { | ||
| if (!val || Object.keys(val).length === 0) { | ||
|
|
@@ -18,6 +19,7 @@ | |
| currencyList = val; | ||
| }, | ||
| }); | ||
| /* eslint-enable rulesdir/prefer-onyx-connect-in-libs */ | ||
|
|
||
| /** | ||
| * Returns the number of digits after the decimal separator for a specific currency. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,8 @@ | |
| import {parsePhoneNumber} from './PhoneNumber'; | ||
|
|
||
| let countryCodeByIPOnyx: number; | ||
| // eslint-disable-next-line rulesdir/prefer-onyx-connect-in-libs -- may refactor to useOnyx/connectWithoutView later | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. doesn't work |
||
| Onyx.connect({ | ||
|
Check warning on line 9 in src/libs/LocalePhoneNumber.ts
|
||
| key: ONYXKEYS.COUNTRY_CODE, | ||
| callback: (val) => (countryCodeByIPOnyx = val ?? 1), | ||
| }); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't work, there's still a warning here.